Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failed to convert mira model to AMR #366

Closed
djinnome opened this issue Sep 18, 2024 · 1 comment
Closed

failed to convert mira model to AMR #366

djinnome opened this issue Sep 18, 2024 · 1 comment

Comments

@djinnome
Copy link
Contributor

Hi folks,

I have the following igfr.xml.gz SBML model that was generated from this igfr.antimony.gz Antimony description.

antimony_fname = "igfr.antimony"
sbml_file = "igfr.xml"
rr_model = te.loada(antimony_fname)
rr_model.exportToSBML(sbml_file)

I was able to load this in Mira,

mira_model = template_model_from_sbml_file(sbml_file)
display(mira_model.parameters)
display(mira_model.initials)

{'k1': Parameter(name='k1', display_name=None, description='', identifiers={}, context={}, units=None, value=400000.0, distribution=None),
 'kd1': Parameter(name='kd1', display_name=None, description='', identifiers={}, context={}, units=None, value=0.002, distribution=None),
 'k1a': Parameter(name='k1a', display_name=None, description='', identifiers={}, context={}, units=None, value=400000.0, distribution=None),
 'kd1a': Parameter(name='kd1a', display_name=None, description='', identifiers={}, context={}, units=None, value=0.002, distribution=None),
 'k3': Parameter(name='k3', display_name=None, description='', identifiers={}, context={}, units=None, value=1e-07, distribution=None),
...

but when I tried to display it in graphviz or convert it to an AMR, I get the same error:

---------------------------------------------------------------------------
UnboundLocalError                         Traceback (most recent call last)
Cell In[6], [line 2](vscode-notebook-cell:?execution_count=6&line=2)
      [1](vscode-notebook-cell:?execution_count=6&line=1) model_json_file_name = "igfr.json"
----> [2](vscode-notebook-cell:?execution_count=6&line=2) community_modeling.convert_MIRA_model_to_petrinet_AMRPetriNetModel(mira_model,model_json_file_name)

File ~/Projects/PPI/CarbStor/concerto/concerto/utils/community_modeling.py:116, in convert_MIRA_model_to_petrinet_AMRPetriNetModel(mira_model, petrinet_model_filename)
    [114](~/Projects/PPI/CarbStor/concerto/concerto/utils/community_modeling.py:114) file_path = Path(petrinet_model_filename)
    [115](~/Projects/PPI/CarbStor/concerto/concerto/utils/community_modeling.py:115) file_root = file_path.stem
--> [116](~/Projects/PPI/CarbStor/concerto/concerto/utils/community_modeling.py:116) petrinet_model = AMRPetriNetModel(Model(mira_model))
    [117](~/Projects/PPI/CarbStor/concerto/concerto/utils/community_modeling.py:117) petrinet_model.to_json_file(
    [118](~/Projects/PPI/CarbStor/concerto/concerto/utils/community_modeling.py:118)             petrinet_model_filename,
    [119](~/Projects/PPI/CarbStor/concerto/concerto/utils/community_modeling.py:119)             name=file_root,
    [120](~/Projects/PPI/CarbStor/concerto/concerto/utils/community_modeling.py:120)             description=file_root,
    [121](~/Projects/PPI/CarbStor/concerto/concerto/utils/community_modeling.py:121)             indent=2,
    [122](~/Projects/PPI/CarbStor/concerto/concerto/utils/community_modeling.py:122)         )

File ~/Projects/PPI/CarbStor/mira/mira/modeling/__init__.py:149, in Model.__init__(self, template_model)
    [147](~/Projects/PPI/CarbStor/mira/mira/modeling/__init__.py:147) self.transitions: Dict[Hashable, Transition] = {}
    [148](~/Projects/PPI/CarbStor/mira/mira/modeling/__init__.py:148) self.observables: Dict[Hashable, ModelObservable] = {}
--> [149](~/Projects/PPI/CarbStor/mira/mira/modeling/__init__.py:149) self.make_model()

File ~/Projects/PPI/CarbStor/mira/mira/modeling/__init__.py:340, in Model.make_model(self)
    [336](~/Projects/PPI/CarbStor/mira/mira/modeling/__init__.py:336) elif not is_replication(template):
    [337](~/Projects/PPI/CarbStor/mira/mira/modeling/__init__.py:337)     produced, produced_key = tuple(), None
    [339](~/Projects/PPI/CarbStor/mira/mira/modeling/__init__.py:339) tkey_elements = tuple(
--> [340](~/Projects/PPI/CarbStor/mira/mira/modeling/__init__.py:340)     element for element in [consumed_key, produced_key, control_key, str(idx)]
    [341](~/Projects/PPI/CarbStor/mira/mira/modeling/__init__.py:341)     if element is not None
    [342](~/Projects/PPI/CarbStor/mira/mira/modeling/__init__.py:342) )
    [343](~/Projects/PPI/CarbStor/mira/mira/modeling/__init__.py:343) tkey = get_transition_key(tkey_elements, template.type)
    [345](~/Projects/PPI/CarbStor/mira/mira/modeling/__init__.py:345) p = self.assemble_parameter(template, tkey)

UnboundLocalError: cannot access local variable 'consumed_key' where it is not associated with a value
@bgyori
Copy link
Member

bgyori commented Sep 23, 2024

Fixed in #368

@bgyori bgyori closed this as completed Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants