Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

HopChar2 command not work when cursor place at the empty line #351

Open
louishuyng opened this issue Jan 12, 2023 · 11 comments
Open

HopChar2 command not work when cursor place at the empty line #351

louishuyng opened this issue Jan 12, 2023 · 11 comments

Comments

@louishuyng
Copy link

HopChar2 command does not work when the cursor is placed at an empty line and shows this error popup below
Screenshot 2023-01-13 at 00 24 27

@louishuyng louishuyng changed the title HopChar2 Not work on the empty line HopChar2 command not work when cursor place at the empty line Jan 12, 2023
@louishuyng
Copy link
Author

louishuyng commented Jan 12, 2023

I raised a PR here for fixing
#350

@nonetallt
Copy link

nonetallt commented Jan 16, 2023

Looking through the history of issues, this one has been raised multiple times in the past and was supposed to fixed. However I can confirm that it's still happening, not sure if it affects all commands (seems likely), but I'm having the same issue with both of these commands:

  • HopWordBC
  • HopWordAC

@yanshay
Copy link

yanshay commented Jan 22, 2023

Also with hop.hint_char1({ direction = directions.AFTER_CURSOR, current_line_only = false })

But not with hop.hint_char1()

@Xlator
Copy link

Xlator commented Jan 28, 2023

Also happening with hop.hint_lines()

@Xlator
Copy link

Xlator commented Jan 30, 2023

Fixed by @aznhe21 (branch fix-some-bugs)

Packer config

use {
    'aznhe21/hop.nvim',
    branch = 'fix-some-bugs', -- optional but strongly recommended
    config = function()
        require'hop'.setup()
    end
}

@awerebea
Copy link

Fixed by @aznhe21 (branch fix-some-bugs)

Why hasn't it merged yet?

@farzadmf
Copy link

farzadmf commented Feb 20, 2023

The repo that supposedly has the fix doesn't event exist! 🤔

Ignore that, the link seems to have a typo; proper repo is https://github.com/aznhe21/hop.nvim (in the config it's correct, but the hyperlink is wrong)

@farzadmf
Copy link

The fixes don't cover my use case: I think it happens where the line doesn't fit the "visible" width (example: having 2 vertical splits besides each other). and you need to "scroll" the line to see the end

@yanshay
Copy link

yanshay commented Apr 8, 2023

a fix submitted in PR #358

@farzadmf
Copy link

@yanshay just a small thing: usually, one only says "fixed" (past tense) after a PR is merged

@yanshay
Copy link

yanshay commented Apr 13, 2023

@yanshay just a small thing: usually, one only says "fixed" (past tense) after a PR is merged

changed the comment accordingly

mss1451 added a commit to mss1451/hop.nvim that referenced this issue Apr 28, 2023
awerebea pushed a commit to awerebea/hop.nvim that referenced this issue Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants