Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

composer require hamcreast #38

Open
stojg opened this issue Mar 16, 2016 · 1 comment · May be fixed by #41
Open

composer require hamcreast #38

stojg opened this issue Mar 16, 2016 · 1 comment · May be fixed by #41

Comments

@stojg
Copy link

stojg commented Mar 16, 2016

It would be neat if hamcrest/hamcrest-php composer required instead of committed to the source code.
@hafriedlander
Copy link
Owner

It would. That didn't use to be possible. It is now. We could even leave it out entirely, and just specify an interface.

madmatt added a commit to madmatt/phockito that referenced this issue Jun 19, 2019
@madmatt
API: Upgrade to hamcrest/hamcrest-php v2.0.0
71622c5 
- Fix references to old classnames (Hamcrest_Matcher -> Hamcrest\Matcher and Hamcrest_Core_IsInstanceOf -> Hamcrest\Core\IsInstanceOf)
- Pull in via composer rather than directly in-lining Hamcrest (fixes hafriedlander#38)
- Resolves the very important hafriedlander#37
- Fixes PhockitoHamcrestTest::testCanStubByType() having the test args around the wrong way (actual, expected instead of expected, actual)
@madmatt madmatt linked a pull request Jun 19, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

API: Upgrade to hamcrest/hamcrest-php v2.0.0 madmatt/phockito
2 participants
@hafriedlander @stojg