Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image as inline vs. block #52

Open
dylans opened this issue Jan 24, 2022 · 2 comments
Open

Image as inline vs. block #52

dylans opened this issue Jan 24, 2022 · 2 comments

Comments

@dylans
Copy link
Contributor

dylans commented Jan 24, 2022

I'm not sure of a great solution, but I think the ast that gets generated doesn't work well for an image if it is an inline element vs. a block.

Perhaps it should get fixed via normalization, but I think for inline it's probably ideal to have an image element have an empty text element before and after. Perhaps this could be handled via a mode, or perhaps there's a good way to infer it from usage.

@newtmex
Copy link
Contributor

newtmex commented Mar 4, 2022

Remark-slate defaults to generating AST with the image as inline. I can't figure how to make it generate it as block.

@hanford
Copy link
Owner

hanford commented Mar 4, 2022

We may want to introduce a new mode or expose an option to enable that. I don't have a strong preference as I don't have any images in the editor that I use!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants