Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Packed array types aren't recognized by REG_PROPERTY #17

Open
chocola-mint opened this issue Oct 25, 2023 · 0 comments
Open

Bug: Packed array types aren't recognized by REG_PROPERTY #17

chocola-mint opened this issue Oct 25, 2023 · 0 comments

Comments

@chocola-mint
Copy link
Contributor

chocola-mint commented Oct 25, 2023

The Variant type enum for pooled array types follows the format PACKED_<type>_ARRAY, not PACKED<type>ARRAY.

Our current implementation just converts the C++ type name to uppercase and append it to Variant::. So PackedInt32Array gets mapped to PACKEDINT32ARRAY, and since Variant::PACKEDINT32ARRAY doesn't exist, the mapping fails and we would refuse to register it.

Instead of simply converting type names to uppercase, we need to convert type names from CamelCase to snake_case, then to uppercase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant