[BUG] Support-bundle should not set error on optional phase

[w13915984028]

Describe the bug

Support-bundle can't work unless disable rancher-monitoring addon

#6891 (comment)

It caused the rancher-monitoring related POD logs can't be collected.

To Reproduce
Steps to reproduce the behavior:

1. It happend per issue [BUG] Pod prometheus-rancher-monitoring can not be started after v1.3.2 => v1.4.0-rc4 upgrade  #6891 when prometheus can't work properly

Expected behavior

SB should work as reliable as possible

https://github.com/rancher/support-bundle-kit/blob/6bd0407236d20de97b38c84a31944fe2d36d9949/pkg/manager/manager.go#L285

Prometheus is broken, above code will return error

harvester/pkg/controller/master/supportbundle/controller.go

Line 152 in 19bc22d

if managerStatus.Error {

...
	if managerStatus.Error {
		return h.setError(sb, managerStatus.ErrorMessage) // will cause SB to be aborted
	}

https://github.com/rancher/support-bundle-kit/blob/6bd0407236d20de97b38c84a31944fe2d36d9949/pkg/manager/manager.go#L189

func (m *SupportBundleManager) runPhase(phase RunPhase, progressCount *int, maxProgressCount int) error {
	logrus.Infof("Running phase %s", phase.Name)
	m.status.SetPhase(phase.Name)
	if err := phase.Run(); err != nil {
		m.status.SetError(err.Error())
		logrus.Errorf("Failed to run phase %s: %s", phase.Name, err.Error())
		return err
	}
...

func (m *SupportBundleManager) runAllPhases(requiredPhases []RunPhase, optionalPhases []RunPhase, postPhases []RunPhase) {

...

	for _, phase := range optionalPhases {
		if err := m.runPhase(phase, &progressCount, maxProgressCount); err != nil {
			logrus.Errorf("Failed to run optionalPhases %s: %s", phase.Name, err.Error())
			// Since it's optional, don't return error.
			continue
		}
	}

Support bundle

Environment

• Harvester ISO version: Harvester v1.4.0-rc4
• Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630):

Additional context

[Yu-Jack]

I also notice that there is a bug for progressCount. If the optional phase gets error, the progressCount doesn't increase. But, it should increase since it's optional. I'll fix this as well.

[harvesterhci-io-github-bot]

Pre Ready-For-Testing Checklist

• If labeled: require/HEP Has the Harvester Enhancement Proposal PR submitted?
  The HEP PR is at:

• Where is the reproduce steps/test steps documented?
  The reproduce steps/test steps are at: Please use v1.4-head to test this feature. Follow steps on this comment to create a fake Prometheus Pod to test.

• Is there a workaround for the issue? If so, where is it documented?
  The workaround is at:

• Have the backend code been merged (harvester, harvester-installer, etc) (including backport-needed/*)?
  The PR is at:
  bump: support bundle kit to v0.0.46 #6905
  fix: shouldn't set error in optional phases rancher/support-bundle-kit#126

  • Does the PR include the explanation for the fix or the feature?

  • Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
    The PR for the YAML change is at:
    The PR for the chart change is at:

• If labeled: area/ui Has the UI issue filed or ready to be merged?
  The UI issue/PR is at:

• If labeled: require/doc, require/knowledge-base Has the necessary document PR submitted or merged?
  The documentation/KB PR is at:

• If NOT labeled: not-require/test-plan Has the e2e test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue?

  • The automation skeleton PR is at:
  • The automation test case PR is at:

• If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility?
  The compatibility issue is filed at:

[harvesterhci-io-github-bot]

Automation e2e test issue: harvester/tests#1632

[brandboat]

Test OK on v1.4-head, will close the issue

Environment

• single node (12C/16G/500GB)
• v1.4-head (c6facee)

Test Plan

• Follow bump: support bundle kit to v0.0.46 #6905, and I can generate support bundle by either enable/disable rancher-monitoring, and when using fake prometheus, I can see logs as follows (support bundle still successfully created)