Query
should be sign-able
#578
janaakhterov
started this conversation in
Ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Currently queries and transactions are mostly distinct on the fact a transaction is sign-able, while a query is not. This doesn't make sense as a query has a payment transaction within it, and should allow those payment transactions to be signed by multiple keys if necessary.
If both transactions and queries are to now going to be sign-able, perhaps this code could be abstracted away into a new private type called
Request
, or we could shove this intoExecutable
like we did fornodeAccountIds
, but I'm not a big fan of that.This is what I have in mind
We could move most of the functionality from
Transaction
into this newRequest
type which would simply bothTransaction
andQuery
. For instance currentlyTransaction
has these fieldsIf we move these fields into
Request
thenQuery
can treattransactions
as the payment transactions, whileTransaction
continues treating these fields as normally does.Beta Was this translation helpful? Give feedback.
All reactions