fix (saml): fix possible panic in WithAdditionalACSEndpoint(...)

changed location url to be passed by value to eliminate possible panic
hashicorp · Sep 9, 2023 · 65cb44c · 65cb44c
1 parent 06396ac
commit 65cb44c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/saml/sp.go b/saml/sp.go
@@ -67,6 +67,7 @@ func WithACSServiceBinding(b core.ServiceBinding) Option {
 }
 
 // WithAdditionalACSEndpoint provides an optional additional ACS endpoint
+func WithAdditionalACSEndpoint(b core.ServiceBinding, location url.URL) Option {
 	return func(o interface{}) {
 		if o, ok := o.(*metadataOptions); ok {
 			o.additionalACSs = append(o.additionalACSs, metadata.Endpoint{

diff --git a/saml/sp_test.go b/saml/sp_test.go
@@ -254,7 +254,7 @@ func Test_CreateMetadata_Options(t *testing.T) {
 		got := provider.CreateMetadata(
 			saml.WithAdditionalACSEndpoint(
 				core.ServiceBindingHTTPRedirect,
-				redirectEndpoint,
+				*redirectEndpoint,
 			),
 		)