saml: minor code improvements #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimlambrt
force-pushed
the
jimlambrt-saml-fixups
branch
from
a0878cf to
6c522d8
Compare
changed location url to be passed by value to eliminate possible panic
Refactor WithAdditionalNameIDFormat(...) and WithNameIDFormats(...) into one new option WithMetadataNameIDFormat(...)
jimlambrt
force-pushed
the
jimlambrt-saml-fixups
branch
3 times, most recently
from
af43639 to
e37bd89
Compare
jimlambrt
force-pushed
the
jimlambrt-saml-fixups
branch
from
e37bd89 to
349a873
Compare
jimlambrt
force-pushed
the
jimlambrt-saml-fixups
branch
from
349a873 to
154b738
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.