Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to the SAML test provider to create signed SAML responses #135

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

hcjulz
Copy link
Collaborator

@hcjulz hcjulz commented Apr 3, 2024

This PR adds the ability to the SAML test provider to create signed SAML responses. It uses the goxmldsig library for this purpose, which is also used by the underlaying gosaml2 library used in cap/saml.

Before, this library used samltest.id (a test SAML Identity provider), which doesn't exist anymore. The tests for parsing SAML responses have been updated to use the test provider.

I'll open a follow up PR to improve the test SAML identity provider in cap/saml. Areas to improve:

  • Provide more options to modify the SAML response, such that we can get rid of any hard coded SAML response XML strings.
  • Create the IDP Metadata programatically with options.

Copy link
Collaborator

@jimlambrt jimlambrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@hcjulz hcjulz merged commit c041881 into main Apr 3, 2024
6 checks passed
@hcjulz hcjulz deleted the use-test-provider branch April 3, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants