Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for target_region replicas field, make error message for it clearer #437

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

JenGoldstrich
Copy link
Contributor

There's been some confusion around the target_region block and its replicas field, this PR fixes an issue where there we weren't including the specific information for the fields the target_region block in the docs. I also modified the error message to make this easier to understand

closes #430

@JenGoldstrich JenGoldstrich requested a review from a team as a code owner August 22, 2024 18:11
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nywilken nywilken added the docs label Aug 22, 2024
@nywilken
Copy link
Contributor

nywilken commented Aug 22, 2024

After merging I suggest running the manual notify integration release job to trigger an ingest of the updated plugins docs for the 2.1.7 release.

@JenGoldstrich JenGoldstrich merged commit 4d2a020 into main Aug 22, 2024
12 checks passed
@JenGoldstrich JenGoldstrich deleted the fix_target_replica_docs branch August 22, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update documentation for target_regions block
2 participants