Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check for the existence of files provided in iso_paths before starting a build. #453

Open
tenthirtyam opened this issue Jul 15, 2024 · 0 comments
Assignees
Milestone

Comments

@tenthirtyam
Copy link
Collaborator

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.

Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request.

If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Description

A .iso file can be provided at an input to iso_paths where the file name may not exist or has been provided with an incorrect case. In such an instance, the CD-ROM will be added but will not connect to the media, resulting in the build failing.

Use Case(s)

Ensure that builds do not proceed if the media can not be found on the data store.

Potential Configuration

Add a check in the Prepare() for step_add_cdrom.go to ensure that the file name provided exists on the datastore before running the build. If the file does not exist, append an error message.

References

#452

@tenthirtyam tenthirtyam added this to the v1.4.0 milestone Jul 15, 2024
@tenthirtyam tenthirtyam self-assigned this Jul 15, 2024
@tenthirtyam tenthirtyam modified the milestones: v1.4.1, v1.5.0 Sep 22, 2024
@tenthirtyam tenthirtyam modified the milestones: v1.5.0, v1.6.0 Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant