vsphere_virtual_disk - create_directories fails if creating multiple disks in parallel in the same directory

[skevir]

Community Guidelines

• I have read and agree to the HashiCorp Community Guidelines .
• Vote on this issue by adding a 👍 reaction to the original issue initial description to help the maintainers prioritize.
• Do not leave "+1" or other comments that do not add relevant information or questions.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Terraform

1.9.8-1

Terraform Provider

2.9.2

VMware vSphere

8.0.1

Description

Provider fails to create all but one of the disks being created in parallel on a vSAN datastore - with errors:

Failed to create parent directories:  ServerFaultCode: A general system error occurred: Invalid fault: timestamp=2024-12-12T14:43:50.019Z
Failed to create parent directories:  ServerFaultCode: Cannot complete the operation because the file or folder [my-vsan-datastore] test-folder already exists: timestamp=2024-12-12T14:43:50.019Z

Looks to be related to #633 (fixed under #639) - maybe the error message has changed so the implementation of isAlreadyExists() no longer spots this case?

Interestingly I see two different errors for different disks (and that looks to also have been the case in issue 633) and it looks like the original fix only covered the one that specifically indicates the folder already exists (not the "general system error" one).

Affected Resources or Data Sources

resource/vsphere_virtual_disk

Terraform Configuration

resource "vsphere_virtual_disk" "test-disk-1" {
size = 10
vmdk_path = "test-folder/test-disk-1.vmdk"
create_directories = true
datacenter = "my-datacenter"
datastore = "my-vsan-datastore"
count = 1
type = "lazy"
}

resource "vsphere_virtual_disk" "test-disk-2" {
size = 10
vmdk_path = "test-folder/test-disk-2.vmdk"
create_directories = true
datacenter = "my-datacenter"
datastore = "my-vsan-datastore"
count = 1
type = "lazy"
}

resource "vsphere_virtual_disk" "test-disk-3" {
size = 10
vmdk_path = "test-folder/test-disk-3.vmdk"
create_directories = true
datacenter = "my-datacenter"
datastore = "my-vsan-datastore"
count = 1
type = "lazy"
}

Debug Output

https://gist.github.com/skevir/1805f2e30e304151acf0256e9c5cfd6c

Panic Output

No response

Expected Behavior

All vsphere_virtual_disks should be created, within the common parent directory.

Actual Behavior

Only one vsphere_virtual_disk is created.

Steps to Reproduce

terraform apply, using a vSAN datastore.

Environment Details

vSAN datastore being used.

Screenshots

No response

References

#633
#639

[skevir]

Hi - any thoughts on this? Is there any additional information you need from me? Thanks.