Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running bin/install doesn't handle Plug not being already installed #90

Open
pcapel opened this issue Jan 30, 2020 · 1 comment
Open
Assignees

Comments

@pcapel
Copy link

pcapel commented Jan 30, 2020

Expectation:

Given I am a person who wants to install dotmatrix
When I run the bin/install script after cloning the repo
Then I should be able to run vim and have Plug installed

Actual Result:

Plug is neither installed or checked for, so the installation of dotmatrix causes vim to spit out a ton of errors related to the missing commands.

We could either run the curl command automatically in the setup script, or we could have the script warn that Plug is missing. Personally I think that installing it is nicest, but it will need to check for the file presence regardless of which path we decide on so I'm open to suggestions otherwise.

@pcapel pcapel self-assigned this Jan 30, 2020
@pcapel
Copy link
Author

pcapel commented Jan 30, 2020

I plan to work on the installation and flow for dotmatrix and other workstation related projects during open source time tomorrow (1-31-20), so any feedback is welcome prior to me creating a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant