Test failure

[bergmark]

This happened on the stackage server, but i couldn't reproduce it locally...

Building test suite 'spec' for servant-swagger-1.1.5..
[1 of 2] Compiling Servant.SwaggerSpec ( test/Servant/SwaggerSpec.hs, dist/build/spec/spec-tmp/Servant/SwaggerSpec.o )
[2 of 2] Compiling Main             ( test/Spec.hs, dist/build/spec/spec-tmp/Main.o )
Linking dist/build/spec/spec ...
> /tmp/stackage-build12/servant-swagger-1.1.5$ dist/build/doctests/doctests
/tmp/stackage-build12/servant-swagger-1.1.5/src/Servant/Swagger.hs:158: failure in expression `hspec $ validateEveryToJSON (Proxy :: Proxy UserAPI)'
expected:
          [User]
          User
          UserId

          Finished in ... seconds
          3 examples, 0 failures
 but got:
          [User]
            +++ OK, passed 100 tests.
          User
            +++ OK, passed 100 tests.
          UserId
            +++ OK, passed 100 tests.

          Finished in 0.1027 seconds
          3 examples, 0 failures

/tmp/stackage-build12/servant-swagger-1.1.5/src/Servant/Swagger/Internal/Test.hs:46: failure in expression `hspec $ context "ToJSON matches ToSchema" $ validateEveryToJSON (Proxy :: Proxy UserAPI)'
expected:
          ToJSON matches ToSchema
            User
            UserId

          Finished in ... seconds
          2 examples, 0 failures
 but got:
          ToJSON matches ToSchema
            User
              +++ OK, passed 100 tests.
            UserId
              +++ OK, passed 100 tests.

          Finished in 0.0066 seconds
          2 examples, 0 failures

/tmp/stackage-build12/servant-swagger-1.1.5/src/Servant/Swagger/Internal/Test.hs:99: failure in expression `:{
  hspec $
    context "read . show == id" $
      props
        (Proxy :: Proxy [Eq, Show, Read])
        (\x -> read (show x) == x)
        (Proxy :: Proxy [Bool, Int, String])
:}'
expected:
          read . show == id
            Bool
            Int
            [Char]

          Finished in ... seconds
          3 examples, 0 failures
 but got:
          read . show == id
            Bool
              +++ OK, passed 100 tests.
            Int
              +++ OK, passed 100 tests.
            [Char]
              +++ OK, passed 100 tests.

          Finished in 0.0145 seconds
          3 examples, 0 failures

Examples: 82  Tried: 77  Errors: 0  Failures: 3

[fizruk]

I think this is because hspec-2.5.0 has changed output for QuickCheck properties and now includes all of it (see hspec/hspec#257).

I will update doctests, although I'm not sure if I need to bump version. @phadej can you advise?

[phadej]

I'd rather do it properly this time:

• make swagger2 test-driver agnostic
• have swagger2-hspec with current hspec functionality
• use something with deterministic output in doctests

[phadej]

... and I'm personally against making releases just to update tests. We can bound hspec version to correct one in released versions, but hold on until we have another reasons to make a release.

[phadej]

Note to self: add bounds to test-dependencies in the next release.

[phadej]

... hmm, i cannot reproduce this. With hspec-2.4 and hspec-2.5 doctests pass fine.

[phadej]

Looks like I already fixed tests 249530d9, but as mentioned, didn't care to make a release because of tests only.

[phadej]

And now, I don't want to make a release before #87 is fixed, even the new prettyValidateWith export in the Internal module.

[bergmark]

Thanks! no problem leaving this without a release for now.