Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.10.0.0 #4434

Open
fendor opened this issue Oct 21, 2024 · 6 comments
Open

Release 2.10.0.0 #4434

fendor opened this issue Oct 21, 2024 · 6 comments
Assignees
Labels
bindists Anything to do with binary distributions of HLS

Comments

@fendor
Copy link
Collaborator

fendor commented Oct 21, 2024

Since GHC 9.8.3 has been published on the 20.10.2024, we need to do an HLS release to support the new GHC version.

Unless I am mistaken, the new release should be for the following GHC versions:

  • 9.4.8
  • 9.6.6
  • 9.8.3
  • 9.10.1

In particular, we dropped support for GHC 9.2 in #4326

@fendor fendor added the bindists Anything to do with binary distributions of HLS label Oct 21, 2024
@fendor
Copy link
Collaborator Author

fendor commented Oct 21, 2024

I can take care of the release in the near future.

Before the release, we want to merge #4392

@fendor
Copy link
Collaborator Author

fendor commented Oct 22, 2024

@hasufell Pinging you so you know we are planning a release soon ™️

@noughtmare
Copy link
Contributor

noughtmare commented Oct 24, 2024

I would really appreciate it if we could also get #4433 in.

@fendor
Copy link
Collaborator Author

fendor commented Oct 25, 2024

Merging #4433 just before the release is quite risky as there is no time to do any dogfooding.
So I don't think we will wait for it if we don't manage to get enough reviews. I pinged a couple of potential reviewers, so perhaps.
As GHC 9.12 is planned to be released in November, there will be another HLS release soon after 2.10.0.0.

@juhp
Copy link
Contributor

juhp commented Oct 28, 2024

Has building with 9.8.3 been tested?: 2.9 fails for me with:

src/Development/IDE/GHC/Compat/Core.hs:712:10: error: [GHC-83865]
    ・ Couldn't match expected type: Maybe String
                  with actual type: Either
                                      String
                                      (ghci-9.8.3:GHCi.RemoteTypes.RemotePtr
                                         ghci-9.8.3:GHCi.Message.LoadedDLL)
    ・ In the first argument of ’pure‘, namely ’res’
      In a stmt of a 'do' block: pure res
      In the expression:
        do res <- GHCi.loadDLL (hscInterp env) str
           pure res
    |
712 |     pure res
    |          ^^^

I should better file an issue I guess - I see in git it is currently conditional on ghc >= 9.11

CI still seems to be using 9.8.2.

@benz0li
Copy link

benz0li commented Oct 28, 2024

I should better file an issue I guess

@juhp No. Wait for 2.10.0.0.

@fendor fendor self-assigned this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bindists Anything to do with binary distributions of HLS
Projects
None yet
Development

No branches or pull requests

4 participants