We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Per the docs
The operation type is either query, mutation, or subscription and describes what type of operation you're intending to do.
However many places in the README, and the library itself conflate 'query' with 'operation'. For example:
Under More Examples we see:
const { query } = require('graphqurl'); query( { query: ` mutation ($id_insert_input: String!, $column_insert_input: String!) {
And later:
query( { query: 'subscription { table { column } }',
Under CLI we see:
gq \ [snip] --variableFile='./queryVariables.json' \ --queryFile='./query.gql
... but there is nothing to stop './query.gql containing a mutation.
'./query.gql
mutation
In the code itself there is a red flag here:
graphqurl/src/query.js
Line 75 in dbe963c
Line 83 in dbe963c
Line 91 in dbe963c
⬆️ per the doc linked at the start of this issue I propose this should definitely be operationType.
operationType
Would you accept a PR to:
Change the README to prefer 'operation' to 'query'.
Rename query.js to operation.js, and: Re-export operation as query (to prevent API breaking change) in
query.js
operation.js
operation
query
graphqurl/src/index.js
Lines 4 to 5 in dbe963c
Add --operationFile to the CLI as an alias of --queryFile
--operationFile
--queryFile
❓
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Per the docs
However many places in the README, and the library itself conflate 'query' with 'operation'. For example:
Under More Examples we see:
And later:
Under CLI we see:
... but there is nothing to stop
'./query.gql
containing amutation
.In the code itself there is a red flag here:
graphqurl/src/query.js
Line 75 in dbe963c
graphqurl/src/query.js
Line 83 in dbe963c
graphqurl/src/query.js
Line 91 in dbe963c
⬆️ per the doc linked at the start of this issue I propose this should definitely be
operationType
.Would you accept a PR to:
Change the README to prefer 'operation' to 'query'.
Rename
query.js
tooperation.js
, and:Re-export
operation
asquery
(to prevent API breaking change) ingraphqurl/src/index.js
Lines 4 to 5 in dbe963c
Add
--operationFile
to the CLI as an alias of--queryFile
❓
The text was updated successfully, but these errors were encountered: