Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cli plugin #27

Merged
merged 11 commits into from
Nov 10, 2024
Merged

feat: cli plugin #27

merged 11 commits into from
Nov 10, 2024

Conversation

hgiasac
Copy link
Collaborator

@hgiasac hgiasac commented Nov 9, 2024

  • Enable the configuration CLI plugin and improve the configuration schema.
  • Add concurrency settings.
  • Support headers forwarding.
  • (Breaking change) Replace env template with an object.
# before
url: "{{FOO_SERVER_URL:-https://onesignal.com/api/v1}}"

# after:
url: 
  env: FOO_SERVER_URL
  value: https://onesignal.com/api/v1
  • (Breaking change) Move retry and timeout policies to the connector configuration.

Copy link

github-actions bot commented Nov 9, 2024

Code Coverage

Package Line Rate Health
github.com/hasura/ndc-rest/connector 51%
github.com/hasura/ndc-rest/connector/internal 54%
github.com/hasura/ndc-rest/ndc-rest-schema/configuration 60%
github.com/hasura/ndc-rest/ndc-rest-schema/openapi/internal 51%
github.com/hasura/ndc-rest/ndc-rest-schema/openapi 33%
github.com/hasura/ndc-rest/ndc-rest-schema/schema 36%
github.com/hasura/ndc-rest/ndc-rest-schema/utils 39%
Summary 50% (2743 / 5477)

Minimum allowed line rate is 40%

@hgiasac hgiasac marked this pull request as ready for review November 10, 2024 17:30
@hgiasac hgiasac merged commit 95a6178 into main Nov 10, 2024
4 checks passed
@hgiasac hgiasac deleted the feat/cli-plugin branch November 10, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant