Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: OAS conversion and trim special characters #30

Merged
merged 5 commits into from
Nov 14, 2024
Merged

fix: OAS conversion and trim special characters #30

merged 5 commits into from
Nov 14, 2024

Conversation

hgiasac
Copy link
Collaborator

@hgiasac hgiasac commented Nov 13, 2024 •
edited
Loading

  • Trim special characters in raw documents to avoid YAML decoding errors
  • Fix various conversion OAS2 and OAS3 bugs .
  • Improve code formatting and linters

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2024 •
edited
Loading

Code Coverage

Package Line Rate Health
github.com/hasura/ndc-http/connector 51% ➖
github.com/hasura/ndc-http/connector/internal 54% ➖
github.com/hasura/ndc-http/ndc-http-schema/configuration 60% ➖
github.com/hasura/ndc-http/ndc-http-schema/openapi/internal 50% ➖
github.com/hasura/ndc-http/ndc-http-schema/openapi 37% ❌
github.com/hasura/ndc-http/ndc-http-schema/schema 37% ❌
github.com/hasura/ndc-http/ndc-http-schema/utils 43% ➖
Summary 50% (2849 / 5703) ➖

Minimum allowed line rate is 40%

@hgiasac hgiasac changed the title fix: OAS 2 conversion and trim special characters fix: OAS conversion and trim special characters Nov 14, 2024
@hgiasac hgiasac merged commit 20f76ab into main Nov 14, 2024
4 checks passed
@hgiasac hgiasac deleted the fix/trim-special-characters branch November 14, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hgiasac