Upgrade smol_str to 0.3 #196
Conversation
jberryman
requested review from
paf31,
codedmart,
daniel-chambers and
danieljharvey
as code owners
|
|
||
| [patch.crates-io] | ||
| # So we can bump the smol_str dependency, since rkyv only supports smol_str>=0.2 :( | ||
| schemars = { git = 'https://github.com/hasura/schemars.git', branch = "v0" } | ||
|
|
There was a problem hiding this comment.
Will this actually work? From what I read in the cargo docs, this patch is not applied to consumers of this library, as all patches need to be defined at the top level.
Remember that [patch] is applicable transitively but can only be defined at the top level so we consumers of my-library have to repeat the [patch] section if necessary.
Source
There was a problem hiding this comment.
Hm I thought I needed this to build the library in isolation, but it seems not. anyway I realized I should probably keep this as a draft until I have something we'd want to merge in v3-engine
There was a problem hiding this comment.
Seems to me like these patches should be applied in the engine codebase because that's where the deps need bumping to be able to use rkyv, no?
Also upgrade schemars to our compatible fork that contains just a version bump. This was motivated by: https://linear.app/hasura/issue/ENG-1279/try-to-move-to-rkyv since rkyv only supports smol_str 0.2 or 0.3 it seems...
jberryman
force-pushed
the
jberryman/upgrade-smol-0.3
branch
from
6464608
to
96e59c2
Compare
Also upgrade schemars to our compatible fork that contains just a version bump.
This was motivated by: https://linear.app/hasura/issue/ENG-1279/try-to-move-to-rkyv since rkyv only supports smol_str 0.2 or 0.3 it seems...
reference/types.mdndc-testif appropriatespecification/capabilities.mdin the specificationndc-test