Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach Already Taken Photos #40

Open
Raeitus opened this issue Jul 29, 2021 · 2 comments
Open

Attach Already Taken Photos #40

Raeitus opened this issue Jul 29, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@Raeitus
Copy link

Raeitus commented Jul 29, 2021

It looks like the only way to attach a photo to a note is to take a photo with your camera on the spot. Would be great if we can add already taken photos to notes as well.

@hauke96 hauke96 added the enhancement New feature or request label Jul 29, 2021
@hauke96
Copy link
Owner

hauke96 commented Jul 29, 2021

Thanks for the suggestion.
However one should not underestimate the effort of implementing this: Whenever a note is deleted by the user, the attached photos are also deleted. But already taken photos should probably not be deleted. So either GeoNotes needs a concept of having "internal" and "external" photos or a selected photo has to be duplicated and then added to the note.

I currently don't know what the best approach might be. There are also a lot of other issues that need to be done so I'm honest, this feature doesn't have the highest priority for me.

@awsomebot
Copy link

I know you've already seen this but I wanted to say I agree with Realmain. It's inconvenient when I take pictures of a place for myself, and then have to take pictures again for the app. Would be much easier if we could just attach an already taken pic, especially when it's for a place I've been to before but can't visit right now.

But I understand why it wouldn't be a priority. Good luck with the app and thanks for making it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants