From fb6fef1b4c557c5d11b7ddc820834d72eef59edf Mon Sep 17 00:00:00 2001 From: Olga Shultseva <150694869+shultseva@users.noreply.github.com> Date: Wed, 11 Sep 2024 10:03:18 +0100 Subject: [PATCH 1/2] Upgrading JVector version to v.3 [AI-155] [AI-133] (#698) With the update to version 3 of the jVector library, the maxBean parameter now represents the maximum degree of the graph, rather than half of the maximum degree. see - https://github.com/jbellis/jvector/blob/main/UPGRADING.md?plain=1#L7 --- hazelcast/vector.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hazelcast/vector.py b/hazelcast/vector.py index 82382d71d2..de46fa7c6f 100644 --- a/hazelcast/vector.py +++ b/hazelcast/vector.py @@ -121,7 +121,7 @@ class IndexConfig: name: str metric: Metric dimension: int - max_degree: int = 16 + max_degree: int = 32 ef_construction: int = 100 use_deduplication: bool = True From cde231252da1aeaf8521cba8badb8198889f2b17 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Y=C3=BCce=20Tekol?= Date: Fri, 20 Sep 2024 14:53:35 +0300 Subject: [PATCH 2/2] Upgrade actions/upload-artifact so nightly tests can be run (#700) Tests cannot be started because `actions/upload-artifact@v2` was deprecated. Upgrading to `v4`. The tests in this PR fail, since they run using the v2 action. --- .github/workflows/coverage_runner.yml | 2 +- .github/workflows/nightly_runner.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/coverage_runner.yml b/.github/workflows/coverage_runner.yml index 0e2017b852..0152ede02c 100644 --- a/.github/workflows/coverage_runner.yml +++ b/.github/workflows/coverage_runner.yml @@ -101,7 +101,7 @@ jobs: override_pr: ${{ github.event.inputs.pr_number }} - name: Upload remote controller logs if test run fails - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v4 if: failure() with: name: rc-logs-${{ matrix.python-version }}-${{ matrix.os }} diff --git a/.github/workflows/nightly_runner.yml b/.github/workflows/nightly_runner.yml index 051728a916..2768c8a5e6 100644 --- a/.github/workflows/nightly_runner.yml +++ b/.github/workflows/nightly_runner.yml @@ -37,7 +37,7 @@ jobs: HZ_SNAPSHOT_INTERNAL_PASSWORD: ${{ secrets.HZ_SNAPSHOT_INTERNAL_PASSWORD }} run: python run_tests.py - name: Upload remote controller logs on test failure - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v4 if: failure() with: name: rc-logs-${{ matrix.python-version }}-${{ matrix.os }}