-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Active Job integration clarification #5672
Comments
👋 I've been working with Olivier on this and was doing some code archeology from discussion on our internal PR. To help answer his question I'm pretty sure this is a leftover from older times, which turned into a little bit of parallel development. The timeline I put together: 18a18e4 (Jun 16, 2012) added the c25312e (Sep 2, 2014) added the section to the readme, which hasn't changed since. This was just before the release of Rails 4.2 on December 19, 2014 which included Active Job and ActionMailer#deliver_later. Meanwhile, 2e442d8 (May 12, 2016) removed the deprecation from the tl;dr I think it's fine to remove the |
Hi,
I was looking into using Active Job to deliver Devise messages, and I am a bit confused:
the README suggests a very simple implementation:
devise/README.md
Lines 694 to 704 in e2242a9
however, source code comments suggest a much more complex implementation:
devise/lib/devise/models/authenticatable.rb
Lines 137 to 208 in 1d66580
AFAICT, the simple implementation works perfectly fine (at least in our codebase).
Is the complex implementation a leftover from older times? Or are there actually any cases where Devise would try to enqueue messages before the record is persisted to the DB?
The text was updated successfully, but these errors were encountered: