From 3fba421a2fd181c38d19550a2b1f23f95e301bce Mon Sep 17 00:00:00 2001
From: Kay Robbins <1189050+VisLab@users.noreply.github.com>
Date: Mon, 7 Oct 2024 14:43:52 -0500
Subject: [PATCH 1/3] Corrected version of changed-files action
---
.github/workflows/verify_source_branch.yaml | 90 ++++++++++-----------
1 file changed, 45 insertions(+), 45 deletions(-)
diff --git a/.github/workflows/verify_source_branch.yaml b/.github/workflows/verify_source_branch.yaml
index 83793a6..186f12b 100644
--- a/.github/workflows/verify_source_branch.yaml
+++ b/.github/workflows/verify_source_branch.yaml
@@ -1,46 +1,46 @@
-name: Verify source branch name
-
-on:
- pull_request:
- branches:
- - '**'
-
-
-jobs:
- verify-source-branch:
- runs-on: ubuntu-latest
- env:
- BRANCH_NAME: ${{ github.head_ref }} # Set the variables used by the verify_branch script
- VALIDATE_ALL: "True"
- steps:
- - name: Checkout code
- uses: actions/checkout@v4
-
- - name: Print source branch name
- run: |
- echo "The source branch of the PR is: $BRANCH_NAME"
-
- - name: Get latest push changes
- id: changed-files
- uses: tj-actions/changed-files@v44
- with:
- since_last_remote_commit: true
-
- - name: Set up Python
- uses: actions/setup-python@v5
- with:
- python-version: '3.10'
-
- - name: Install Pre-commit
- run: pip install pre-commit
-
- - name: Install dependencies
- run: pip install git+https://github.com/hed-standard/hed-python.git@develop
-
- - name: Run pre-commit on changed files
- run: |
- if [ -n "${{ steps.changed-files.outputs.all_changed_files }}" ]; then
- pre-commit run --files ${{ steps.changed-files.outputs.all_changed_files }}
- else
- echo "No files have changed, skipping pre-commit."
+name: Verify source branch name
+
+on:
+ pull_request:
+ branches:
+ - '**'
+
+
+jobs:
+ verify-source-branch:
+ runs-on: ubuntu-latest
+ env:
+ BRANCH_NAME: ${{ github.head_ref }} # Set the variables used by the verify_branch script
+ VALIDATE_ALL: "True"
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v4
+
+ - name: Print source branch name
+ run: |
+ echo "The source branch of the PR is: $BRANCH_NAME"
+
+ - name: Get latest push changes
+ id: changed-files
+ uses: tj-actions/changed-files@v4
+ with:
+ since_last_remote_commit: true
+
+ - name: Set up Python
+ uses: actions/setup-python@v5
+ with:
+ python-version: '3.10'
+
+ - name: Install Pre-commit
+ run: pip install pre-commit
+
+ - name: Install dependencies
+ run: pip install git+https://github.com/hed-standard/hed-python.git@develop
+
+ - name: Run pre-commit on changed files
+ run: |
+ if [ -n "${{ steps.changed-files.outputs.all_changed_files }}" ]; then
+ pre-commit run --files ${{ steps.changed-files.outputs.all_changed_files }}
+ else
+ echo "No files have changed, skipping pre-commit."
fi
\ No newline at end of file
From b1dbdd335430853bdb9653a3e6e026d85465daaf Mon Sep 17 00:00:00 2001
From: Kay Robbins <1189050+VisLab@users.noreply.github.com>
Date: Mon, 7 Oct 2024 15:50:41 -0500
Subject: [PATCH 2/3] Updated the valueClass for samplingRate to numericClass
---
standard_schema/prerelease/HED8.4.0.mediawiki | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/standard_schema/prerelease/HED8.4.0.mediawiki b/standard_schema/prerelease/HED8.4.0.mediawiki
index 74548fb..3158e2b 100644
--- a/standard_schema/prerelease/HED8.4.0.mediawiki
+++ b/standard_schema/prerelease/HED8.4.0.mediawiki
@@ -691,7 +691,7 @@ Each term in this vocabulary has a human-readable description and may include ad
***** Refresh-rate {hedId=HED_0012651} [The frequency with which the image on a computer monitor or similar electronic display screen is refreshed, usually expressed in hertz.]
****** # {takesValue, valueClass=numericClass, hedId=HED_0012652}
***** Sampling-rate {hedId=HED_0012653} [The number of digital samples taken or recorded per unit of time.]
-****** # {takesValue, unitClass=frequencyUnits, hedId=HED_0012654}
+****** # {takesValue, valueClass=numericClass,unitClass=frequencyUnits, hedId=HED_0012654}
***** Speed {hedId=HED_0012655} [A scalar measure of the rate of movement of the object expressed either as the distance traveled divided by the time taken (average speed) or the rate of change of position with respect to time at a particular point (instantaneous speed). The direction of change should be given separately.]
****** # {takesValue, valueClass=numericClass, unitClass=speedUnits, hedId=HED_0012656}
***** Temporal-rate {hedId=HED_0012657} [The number of items per unit of time.]
From 44ac178f77a886f625f51cdedb628335c2865190 Mon Sep 17 00:00:00 2001
From: GitHub Actions
Date: Mon, 7 Oct 2024 20:51:33 +0000
Subject: [PATCH 3/3] Automated schema changes
---
standard_schema/prerelease/HED8.4.0.mediawiki | 2 +-
standard_schema/prerelease/HED8.4.0.xml | 4 ++++
standard_schema/prerelease/hedtsv/HED8.4.0/HED8.4.0_Tag.tsv | 2 +-
3 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/standard_schema/prerelease/HED8.4.0.mediawiki b/standard_schema/prerelease/HED8.4.0.mediawiki
index 3158e2b..37fe28b 100644
--- a/standard_schema/prerelease/HED8.4.0.mediawiki
+++ b/standard_schema/prerelease/HED8.4.0.mediawiki
@@ -691,7 +691,7 @@ Each term in this vocabulary has a human-readable description and may include ad
***** Refresh-rate {hedId=HED_0012651} [The frequency with which the image on a computer monitor or similar electronic display screen is refreshed, usually expressed in hertz.]
****** # {takesValue, valueClass=numericClass, hedId=HED_0012652}
***** Sampling-rate {hedId=HED_0012653} [The number of digital samples taken or recorded per unit of time.]
-****** # {takesValue, valueClass=numericClass,unitClass=frequencyUnits, hedId=HED_0012654}
+****** # {takesValue, valueClass=numericClass, unitClass=frequencyUnits, hedId=HED_0012654}
***** Speed {hedId=HED_0012655} [A scalar measure of the rate of movement of the object expressed either as the distance traveled divided by the time taken (average speed) or the rate of change of position with respect to time at a particular point (instantaneous speed). The direction of change should be given separately.]
****** # {takesValue, valueClass=numericClass, unitClass=speedUnits, hedId=HED_0012656}
***** Temporal-rate {hedId=HED_0012657} [The number of items per unit of time.]
diff --git a/standard_schema/prerelease/HED8.4.0.xml b/standard_schema/prerelease/HED8.4.0.xml
index dc3ee47..e2a0f23 100644
--- a/standard_schema/prerelease/HED8.4.0.xml
+++ b/standard_schema/prerelease/HED8.4.0.xml
@@ -6085,6 +6085,10 @@ Each term in this vocabulary has a human-readable description and may include ad
takesValue
+
+ valueClass
+ numericClass
+
unitClass
frequencyUnits
diff --git a/standard_schema/prerelease/hedtsv/HED8.4.0/HED8.4.0_Tag.tsv b/standard_schema/prerelease/hedtsv/HED8.4.0/HED8.4.0_Tag.tsv
index 9bdff76..032ce5e 100644
--- a/standard_schema/prerelease/hedtsv/HED8.4.0/HED8.4.0_Tag.tsv
+++ b/standard_schema/prerelease/hedtsv/HED8.4.0/HED8.4.0_Tag.tsv
@@ -679,7 +679,7 @@ HED_0012650 Jerk-rate-# 6 Jerk-rate takesValue, valueClass=numericClass, unitCla
HED_0012651 Refresh-rate 5 Rate-of-change The frequency with which the image on a computer monitor or similar electronic display screen is refreshed, usually expressed in hertz.
HED_0012652 Refresh-rate-# 6 Refresh-rate takesValue, valueClass=numericClass Refresh-rate and (valueClass some numericClass)
HED_0012653 Sampling-rate 5 Rate-of-change The number of digital samples taken or recorded per unit of time.
-HED_0012654 Sampling-rate-# 6 Sampling-rate takesValue, unitClass=frequencyUnits Sampling-rate and (unitClass some frequencyUnits)
+HED_0012654 Sampling-rate-# 6 Sampling-rate takesValue, valueClass=numericClass, unitClass=frequencyUnits Sampling-rate and (valueClass some numericClass) and (unitClass some frequencyUnits)
HED_0012655 Speed 5 Rate-of-change A scalar measure of the rate of movement of the object expressed either as the distance traveled divided by the time taken (average speed) or the rate of change of position with respect to time at a particular point (instantaneous speed). The direction of change should be given separately.
HED_0012656 Speed-# 6 Speed takesValue, valueClass=numericClass, unitClass=speedUnits Speed and (valueClass some numericClass) and (unitClass some speedUnits)
HED_0012657 Temporal-rate 5 Rate-of-change The number of items per unit of time.