Merge pull request #619 from VisLab/develop

Modified definition test with no group
hed-standard · Sep 13, 2024 · 6cdf4d8 · 6cdf4d8
2 parents abc9923 + f9637a9
commit 6cdf4d8
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 14 deletions.
diff --git a/docs/source/Appendix_A.md b/docs/source/Appendix_A.md
@@ -190,11 +190,11 @@ behavior of certain value classes (for example the `numericClass` value class).
 * - nameClass
   - `alphanumeric`, `hyphen`, `underscore`, `nonascii` 
 * - numericClass
-  - `digits`,  `period`,  `hyphen`,  `plus`, 'caret`,  `E`,  `e` `
+  - `digits`,  `period`,  `hyphen`,  `plus`, `caret`,  `E`,  `e` `
 * - posixPath
   -  As yet unspecified.
 * - textClass
-  - `printable` or `nonascii` excluding curly braces.
+  - `printable` or `nonascii` excluding curly braces, commas, and single quotes.
 * - IRIClass
   - Valid International Resource Identifier as standardized by [rfc3987](https://datatracker.ietf.org/doc/html/rfc3987).
 ``````
@@ -215,6 +215,7 @@ A BIDS regular expression for this is:
 5. Values of `numericClass` must be equivalent to a valid floating point value.
 6. Scientific notation is supported with the `numericClass`.
 7. The `textClass` is for descriptions, mainly for use with the `Description` tag or schema element descriptions.
+It is also allowed as the value for other tags such as
 8. The `posixPath` class is as yet unspecified and currently allows any characters except commas.
 9. The IRIClass validity is determined by a library implementing the IETF rfc3987 standard.
 

diff --git a/tests/javascript_tests.json b/tests/javascript_tests.json
@@ -847,7 +847,7 @@
         "alt_codes": [
             "TAG_EMPTY"
         ],
-        "name": "definition-invalid-missing-inner-group",
+        "name": "definition-invalid-empty-inner-group",
         "description": "A definition's enclosing tag group has an empty inner group (i.e., the definition's contents).",
         "warning": false,
         "schema": "8.3.0",
@@ -5124,7 +5124,7 @@
                             }
                         },
                         "response": {
-                            "HED": "Label/#"
+                            "Description": "This is a response"
                         }
                     }
                 ],
@@ -5154,7 +5154,7 @@
                                     "face": "Statistical-accuracy/0.677, {response}"
                                 }
                             },
-                            "response": "Label/#"
+                            "response": "This is a response"
                         },
                         "events": [
                             [
@@ -9763,7 +9763,7 @@
                         [
                             4.5,
                             0,
-                            "Delay/1.0 s, (Red))"
+                            "Delay/1.0 s, (Red)"
                         ]
                     ]
                 ],

diff --git a/tests/json_tests/DEFINITION_INVALID.json b/tests/json_tests/DEFINITION_INVALID.json
@@ -84,8 +84,7 @@
     {
         "error_code": "DEFINITION_INVALID",
         "alt_codes": ["TAG_EMPTY"],
-        "name": "definition-invalid-missing-inner-group",
-        "description": "A definition's enclosing tag group has an empty inner group (i.e., the definition's contents).",
+g        "description": "A definition's enclosing tag group has an empty inner group (i.e., the definition's contents).",
         "warning": false,
         "schema": "8.3.0",
         "definitions": ["(Definition/Acc/#, (Acceleration/#, Red))", "(Definition/MyColor, (Label/Pie))"],

diff --git a/tests/json_tests/SIDECAR_INVALID.json b/tests/json_tests/SIDECAR_INVALID.json
@@ -214,7 +214,7 @@
                             }
                         },
                         "response": {
-                            "HED": "Label/#"
+                            "Description": "This is a response"
                         }
                     }
                 ],
@@ -246,7 +246,7 @@
                                     "face": "Statistical-accuracy/0.677, {response}"
                                 }
                             },
-                            "response": "Label/#"
+                            "response": "This is a response"
                         },
                         "events": [
                             [

diff --git a/tests/python_tests.json b/tests/python_tests.json
@@ -847,7 +847,7 @@
         "alt_codes": [
             "TAG_EMPTY"
         ],
-        "name": "definition-invalid-missing-inner-group",
+        "name": "definition-invalid-empty-inner-group",
         "description": "A definition's enclosing tag group has an empty inner group (i.e., the definition's contents).",
         "warning": false,
         "schema": "8.3.0",
@@ -7966,7 +7966,7 @@
                             }
                         },
                         "response": {
-                            "HED": "Label/#"
+                            "Description": "This is a response"
                         }
                     }
                 ],
@@ -7996,7 +7996,7 @@
                                     "face": "Statistical-accuracy/0.677, {response}"
                                 }
                             },
-                            "response": "Label/#"
+                            "response": "This is a response"
                         },
                         "events": [
                             [
@@ -12898,7 +12898,7 @@
                         [
                             4.5,
                             0,
-                            "Delay/1.0 s, (Red))"
+                            "Delay/1.0 s, (Red)"
                         ]
                     ]
                 ],