From 4cd2a6fbf3194d09657e8b0a5c791fef417ed064 Mon Sep 17 00:00:00 2001 From: Kay Robbins <1189050+VisLab@users.noreply.github.com> Date: Fri, 13 Sep 2024 09:59:32 -0500 Subject: [PATCH 1/3] Reran consolidation tests --- tests/javascript_tests.json | 1 - tests/json_tests/DEFINITION_INVALID.json | 2 +- tests/python_tests.json | 1 - 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/tests/javascript_tests.json b/tests/javascript_tests.json index e490d89..992296d 100644 --- a/tests/javascript_tests.json +++ b/tests/javascript_tests.json @@ -847,7 +847,6 @@ "alt_codes": [ "TAG_EMPTY" ], - "name": "definition-invalid-empty-inner-group", "description": "A definition's enclosing tag group has an empty inner group (i.e., the definition's contents).", "warning": false, "schema": "8.3.0", diff --git a/tests/json_tests/DEFINITION_INVALID.json b/tests/json_tests/DEFINITION_INVALID.json index a5ae4dc..21bcc57 100644 --- a/tests/json_tests/DEFINITION_INVALID.json +++ b/tests/json_tests/DEFINITION_INVALID.json @@ -84,7 +84,7 @@ { "error_code": "DEFINITION_INVALID", "alt_codes": ["TAG_EMPTY"], -g "description": "A definition's enclosing tag group has an empty inner group (i.e., the definition's contents).", + "description": "A definition's enclosing tag group has an empty inner group (i.e., the definition's contents).", "warning": false, "schema": "8.3.0", "definitions": ["(Definition/Acc/#, (Acceleration/#, Red))", "(Definition/MyColor, (Label/Pie))"], diff --git a/tests/python_tests.json b/tests/python_tests.json index 5e9329d..d47de55 100644 --- a/tests/python_tests.json +++ b/tests/python_tests.json @@ -847,7 +847,6 @@ "alt_codes": [ "TAG_EMPTY" ], - "name": "definition-invalid-empty-inner-group", "description": "A definition's enclosing tag group has an empty inner group (i.e., the definition's contents).", "warning": false, "schema": "8.3.0", From 82bbcbb67c24c7205e09a34254fdf4de64481864 Mon Sep 17 00:00:00 2001 From: Kay Robbins <1189050+VisLab@users.noreply.github.com> Date: Fri, 13 Sep 2024 10:20:39 -0500 Subject: [PATCH 2/3] Updated JSON tests (#623) * Updated test versions to 8.3.0 and clarified conditions for TAG_INVALID * Merged NODE_NAME_EMPTY into TAG_INVALID * Corrected additional NODE_NAME_EMPTY_LINKS * Lower the schema version on two tests back * Made hed_error_codes.json only contain codes with json files * Add hedID validation tests * Updated some of invalid characters * Updated the JSON tests to have all fields * Updated tests to include warning and alt_code in non-schema tests * Updated the tests with additional alt-codes * Definition may have no inner group * Minor update in appendix B errors * Minor changes to tests * Corrected a typo in the specification * Correction to curly brace test * Modified the test for definition with no group * Updated consolidated json tests (#622) * Updated tests and descriptions of duration handling (#620) * Updated test versions to 8.3.0 and clarified conditions for TAG_INVALID * Merged NODE_NAME_EMPTY into TAG_INVALID * Corrected additional NODE_NAME_EMPTY_LINKS * Lower the schema version on two tests back * Made hed_error_codes.json only contain codes with json files * Add hedID validation tests * Updated some of invalid characters * Updated the JSON tests to have all fields * Updated tests to include warning and alt_code in non-schema tests * Updated the tests with additional alt-codes * Definition may have no inner group * Minor update in appendix B errors * Minor changes to tests * Corrected a typo in the specification * Correction to curly brace test * Modified the test for definition with no group --------- Co-authored-by: IanCa * Updated spec tests and description of Duration handling (#621) * Updated test versions to 8.3.0 and clarified conditions for TAG_INVALID * Merged NODE_NAME_EMPTY into TAG_INVALID * Corrected additional NODE_NAME_EMPTY_LINKS * Lower the schema version on two tests back * Made hed_error_codes.json only contain codes with json files * Add hedID validation tests * Updated some of invalid characters * Updated the JSON tests to have all fields * Updated tests to include warning and alt_code in non-schema tests * Updated the tests with additional alt-codes * Definition may have no inner group * Minor update in appendix B errors * Minor changes to tests * Corrected a typo in the specification * Correction to curly brace test * Modified the test for definition with no group --------- Co-authored-by: IanCa * Reran consolidation tests --------- Co-authored-by: IanCa --------- Co-authored-by: IanCa --- tests/json_tests/DEFINITION_INVALID.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/json_tests/DEFINITION_INVALID.json b/tests/json_tests/DEFINITION_INVALID.json index a5ae4dc..28432cd 100644 --- a/tests/json_tests/DEFINITION_INVALID.json +++ b/tests/json_tests/DEFINITION_INVALID.json @@ -84,7 +84,8 @@ { "error_code": "DEFINITION_INVALID", "alt_codes": ["TAG_EMPTY"], -g "description": "A definition's enclosing tag group has an empty inner group (i.e., the definition's contents).", + "name": "definition-invalid-empty-inner-group", + "description": "A definition's enclosing tag group has an empty inner group (i.e., the definition's contents).", "warning": false, "schema": "8.3.0", "definitions": ["(Definition/Acc/#, (Acceleration/#, Red))", "(Definition/MyColor, (Label/Pie))"], From a3018a1cba57d266e99a7304dfa148ac430a364e Mon Sep 17 00:00:00 2001 From: Kay Robbins <1189050+VisLab@users.noreply.github.com> Date: Fri, 13 Sep 2024 10:25:25 -0500 Subject: [PATCH 3/3] Updated the tests to correct syntax problems --- tests/javascript_tests.json | 1 + tests/python_tests.json | 1 + 2 files changed, 2 insertions(+) diff --git a/tests/javascript_tests.json b/tests/javascript_tests.json index 992296d..e490d89 100644 --- a/tests/javascript_tests.json +++ b/tests/javascript_tests.json @@ -847,6 +847,7 @@ "alt_codes": [ "TAG_EMPTY" ], + "name": "definition-invalid-empty-inner-group", "description": "A definition's enclosing tag group has an empty inner group (i.e., the definition's contents).", "warning": false, "schema": "8.3.0", diff --git a/tests/python_tests.json b/tests/python_tests.json index d47de55..5e9329d 100644 --- a/tests/python_tests.json +++ b/tests/python_tests.json @@ -847,6 +847,7 @@ "alt_codes": [ "TAG_EMPTY" ], + "name": "definition-invalid-empty-inner-group", "description": "A definition's enclosing tag group has an empty inner group (i.e., the definition's contents).", "warning": false, "schema": "8.3.0",