Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary dependency on oldest-supported-numpy #260

Closed
wshanks opened this issue Jul 7, 2024 · 5 comments
Closed

Unnecessary dependency on oldest-supported-numpy #260

wshanks opened this issue Jul 7, 2024 · 5 comments

Comments

@wshanks
Copy link

wshanks commented Jul 7, 2024

oldest-supported-numpy was intended to be used as a build dependency before numpy 2 (which has backwards ABI compatibility). It should not be needed as a runtime dependency (just numpy). Also, since gdstk dropped support for Python 3.8, oldest-supported-numpy should not be needed as a build dependency either.

heitzmann added a commit that referenced this issue Jul 8, 2024
Signed-off-by: Lucas Heitzmann Gabrielli <heitzmann@gmail.com>
@daquinteroflex
Copy link

@heitzmann I think this might be related to the poetry resolution issue too flexcompute/tidy3d#1913 according to python-poetry/poetry#8830 and hence the unclear error on the lockfile resolution in python-poetry/poetry#9659 for an empty project with numpy and gdstk as a dependency.

Suspect a new release with this change sounds like it might solve this environment issue. What do you think?

@heitzmann
Copy link
Owner

heitzmann commented Aug 30, 2024 via email

@daquinteroflex
Copy link

Hi Lucas,

image

I'm just going from this commit history, seems like this PR was merged after the 0.9.53 tag?

@heitzmann
Copy link
Owner

heitzmann commented Aug 31, 2024 via email

@daquinteroflex
Copy link

Thanks a lot Lucas! Indeed the poetry lockfile resolution is now working properly with this release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants