-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unnecessary dependency on oldest-supported-numpy #260
Comments
Signed-off-by: Lucas Heitzmann Gabrielli <heitzmann@gmail.com>
@heitzmann I think this might be related to the poetry resolution issue too flexcompute/tidy3d#1913 according to python-poetry/poetry#8830 and hence the unclear error on the lockfile resolution in python-poetry/poetry#9659 for an empty project with numpy and gdstk as a dependency. Suspect a new release with this change sounds like it might solve this environment issue. What do you think? |
The newest release already includes this fix. 'oldest-supported-numpy' has
already been removed, or did I forget anything else?
…On Fri, Aug 30, 2024, 18:18 Dario Quintero (Flexcompute) < ***@***.***> wrote:
@heitzmann <https://github.com/heitzmann> I think this might be related
to the poetry resolution issue too flexcompute/tidy3d#1913
<flexcompute/tidy3d#1913> according to
python-poetry/poetry#8830
<python-poetry/poetry#8830> and hence the
unclear error on the lockfile resolution in python-poetry/poetry#9659
<python-poetry/poetry#9659> for an empty
project with numpy and gdstk as a dependency.
Suspect a new release with this change sounds like it might solve this
environment issue. What do you think?
—
Reply to this email directly, view it on GitHub
<#260 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABNJ2E2Z7K3DSNCN5JHFFVTZUDOTDAVCNFSM6AAAAABKPS34DKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRSGM2TCMZZGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
My bad, I was assuming these changes had already been released! I've
triggered a new version release right now to include them.
…On Fri, Aug 30, 2024, 19:08 Dario Quintero (Flexcompute) < ***@***.***> wrote:
Hi Lucas,
image.png (view on web)
<https://github.com/user-attachments/assets/d80a8709-1a98-410d-94f1-9d37a39eec55>
I'm just going from this commit history, seems like this PR was merged
after the 0.9.53 tag?
—
Reply to this email directly, view it on GitHub
<#260 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABNJ2E4P3SX3CZCZ2QE5W5TZUDUPVAVCNFSM6AAAAABKPS34DKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRSGQZDIMRRGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Thanks a lot Lucas! Indeed the poetry lockfile resolution is now working properly with this release |
oldest-supported-numpy was intended to be used as a build dependency before numpy 2 (which has backwards ABI compatibility). It should not be needed as a runtime dependency (just numpy). Also, since gdstk dropped support for Python 3.8, oldest-supported-numpy should not be needed as a build dependency either.
The text was updated successfully, but these errors were encountered: