-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow filtering to release only certain packages #196
Comments
colearendt
added a commit
to rstudio/helm
that referenced
this issue
Jul 11, 2022
… issue comment This allows for releasing (in an adhoc fashion) from a branch. Unfortunately the behavior and how this will work for non-devel releases is not super well-defined. If chart-releaser adds support for filtering to only certain releases, that would be helpful to make this safer: helm/chart-releaser#196 In particular, it is most concerning if chart A moves to `--devel` version on the `dev` branch, chart B moves to a newer version on `main`, and then CI runs. It would also be concerning if chart A or chart B move to a newer version on a branch and then publish a "non-devel" version from the branch.
colearendt
added a commit
to rstudio/helm
that referenced
this issue
Jul 11, 2022
… issue comment This allows for releasing (in an adhoc fashion) from a branch. Unfortunately the behavior and how this will work for non-devel releases is not super well-defined. If chart-releaser adds support for filtering to only certain releases, that would be helpful to make this safer: helm/chart-releaser#196 In particular, it is most concerning if chart A moves to `--devel` version on the `dev` branch, chart B moves to a newer version on `main`, and then CI runs based on a `/release-adhoc` comment. It would also be concerning if chart A or chart B move to a newer version on a branch and then publish a "non-devel" version from the branch. It requires being an `OWNER` on the repository, although it is unclear if this correlates to `ADMIN` privileges within the organization.
colearendt
added a commit
to rstudio/helm
that referenced
this issue
Jul 12, 2022
… issue comment This allows for releasing (in an adhoc fashion) from a branch. Unfortunately the behavior and how this will work for non-devel releases is not super well-defined. If chart-releaser adds support for filtering to only certain releases, that would be helpful to make this safer: helm/chart-releaser#196 In particular, it is most concerning if chart A moves to `--devel` version on the `dev` branch, chart B moves to a newer version on `main`, and then CI runs based on a `/release-adhoc` comment. It would also be concerning if chart A or chart B move to a newer version on a branch and then publish a "non-devel" version from the branch. It requires being an `OWNER` on the repository, although it is unclear if this correlates to `ADMIN` privileges within the organization.
@unguiculus @cpanato Is the project willing to make that change? I could create a PR for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In some contexts, it would be nice to have a mechanism for excluding packages from being published, or by contrast, choosing explicitly which packages should be published.
i.e.
cr upload --include='package1*'
orcr upload --exclude='packages*'
This could be particularly useful with https://github.com/helm/chart-releaser-action and
devel
orrc
releases off of non-main
It may also be helpful to have a check/flag that would only released
--devel
versions of a chart. (So you do not risk CI failure or a false publish of a branch to a version that is not desired)Expected workflow with GitHub Actions:
/release-devel some-package
, which triggers a devel/rc release ofsome-package
, but does not check or potentially release others, and would error ifsome-package
had a version defined other than a--devel
versionAlternatively, run on a
dev
branch and only trigger on--devel
versionsThe text was updated successfully, but these errors were encountered: