Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make argument attribute optional (true by default) in <param> from <inputs> during export #14

Open
khillion opened this issue Apr 19, 2017 · 2 comments

Comments

@khillion
Copy link
Collaborator

Hi,

I realized that if we do not precise that positional = True, the argument attribute is automatically added to any <param>.

What do you think if we remove this behaviour and just let the author decide the presence of this attribute like any other optional one?

Thanks.

@hexylena
Copy link
Owner

My thoughts:

  • Argument was added to map the CLI flag to Galaxy in a better way than specifying it at the end of the help="". This way:
    • The galaxy user of a tool could get an idea of which flags correspond to the command line flags, and maybe run from command line with the same flags
    • A colleague was using the reverse mapping and providing CLI wrappers for galaxy tools. His users could invoke the CLI tool and the parameters would go to the correct places in Galaxy.
  • Adding the flag was part of IUC best practices, but those docs have not been updated to reflect the new argument option.

Let me phrase it this way, if you wish to add an option to gxt.Tool or tool.export() that enables / disables the argument, I think that would be fine, but I would prefer to use the IUC best practices as a default state.

@khillion
Copy link
Collaborator Author

Thanks, I get it now! I think using the IUC best practices is the way to go so let's add an option to either gxt.Tool or tool.export().

@khillion khillion changed the title remove automatic argument attribute in <param> from <inputs> make argument attribute optional (true by default) in <param> from <inputs> during export Apr 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants