Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESM module #518

Open
danchitnis opened this issue Oct 6, 2024 · 7 comments
Open

ESM module #518

danchitnis opened this issue Oct 6, 2024 · 7 comments

Comments

@danchitnis
Copy link

Hello, and thanks for the excellent work. Are there any plans to migrate the openmoji's npm module to ESM? It seems it is still using old style commonJS and require.

@b-g
Copy link
Member

b-g commented Oct 7, 2024

I'm afraid this is currently not planned. We simply don't have the resources to keep everything up to date. It is already tough to keep up with the emojis. Sorry!

@b-g b-g closed this as completed Oct 7, 2024
@danchitnis
Copy link
Author

If you keep this issue open, I will see if I can help add the ESM part.

@b-g
Copy link
Member

b-g commented Oct 7, 2024

That would be brilliant! Any help is very welcome. But be warned this is a lot to refactor, see scripts in folder /helpers/ :)

@b-g b-g reopened this Oct 7, 2024
@danchitnis
Copy link
Author

I will run a small-scale test, then, if it works, I will work on a PR. Joining esm with the existing code is a challenge because of all the npm and JS shenanigans, but let's take it step by step!

@nataliakeniganti
Copy link
Contributor

nataliakeniganti commented Oct 7, 2024

A fix esm module?

@danchitnis
Copy link
Author

A fix esm module?

ESM for browsers and bundlers such as parcel, vite, esbuild, etc

@pasanflo
Copy link

pasanflo commented Nov 11, 2024

Hi @danchitnis, I'm a front-end dev with some experience in vitest if testing is needed,but I haven´t done anything similar to porting a project to EcmaScript Modules.

Feel free to get in touch if you need a hand with this, I'm willing to learn about migration to ESM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants
@b-g @pasanflo @danchitnis @nataliakeniganti and others