Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: don't delete coverage reports for non-modified packages #22

Open
PaulRBerg opened this issue Aug 13, 2021 · 3 comments
Open

CI: don't delete coverage reports for non-modified packages #22

PaulRBerg opened this issue Aug 13, 2021 · 3 comments
Labels
bug Something isn't working stale Not going to implement soon

Comments

@PaulRBerg
Copy link
Contributor

When only 1/3 or 2/3 of packages have been modified, the Coveralls GitHub action deletes the previous coverage report for the non-modified packages.

Capture d’écran 2021-08-13 à 15 01 46

Capture d’écran 2021-08-13 à 15 02 47
@PaulRBerg PaulRBerg added the bug Something isn't working label Aug 13, 2021
@PaulRBerg
Copy link
Contributor Author

Fixed via 2a8a6bd.

@PaulRBerg
Copy link
Contributor Author

This started happening again ... E.g. https://github.com/hifi-finance/hifi/actions/runs/1238767426 uploaded coverage only for the flash-swap package.

Capture d’écran 2021-09-16 à 12 57 16

@PaulRBerg PaulRBerg reopened this Sep 16, 2021
@PaulRBerg PaulRBerg changed the title Do not delete coverage reports for non-modified packages CI: don't delete coverage reports for non-modified packages Sep 16, 2021
@PaulRBerg PaulRBerg mentioned this issue Sep 16, 2021
Open
@PaulRBerg
Copy link
Contributor Author

Until #47 gets fixed, this issue is stale.

@PaulRBerg PaulRBerg added the stale Not going to implement soon label Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working stale Not going to implement soon
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PaulRBerg