Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make error codes consistent #13

Open
JohannesOehm opened this issue Nov 25, 2021 · 0 comments
Open

Make error codes consistent #13

JohannesOehm opened this issue Nov 25, 2021 · 0 comments

Comments

@JohannesOehm
Copy link

For example, in websocket_api.ts, errors are handled as follows (line 389):

console.error(
"dataError",
`There was en error executing the procedure [code: 3]: (${procedureName}) ${error}`
)

this.saveToCache(
undefined,
// { data: undefined },
payload,
"raw_data",
procedureName,
error
)
client.emit(
"dataError",
`There was en error executing the procedure [code: 2]: ${error}`
)

As you can see, there is a different error code written to the command line then the error code submitted to the client. This leads the user to the impression, that there are different error codes. Please fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant