Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(28015): Align frontend and backend #655

Merged
merged 39 commits into from
Nov 29, 2024

Conversation

vanch3d
Copy link
Contributor

@vanch3d vanch3d commented Nov 25, 2024

See https://hivemq.kanbanize.com/ctrl_board/57/cards/28015/details/

This PR is yet another refactoring of the frontend to try and align with the backend changes.

  • update the missing required properties in many APis
  • remove client-related functionality
  • refactor handling of tags and topic filters
  • refactor mapping
  • refactor sampling

The new design includes the following changes:

  • xxxToMQTT and mqttToXXX mappings have been "disabled" from the current main adapter
  • tags are editable from the workspace (check on the device node)
  • topic filters are editable from the workspace (check the edge node)
  • inward and outward mappings are now available from the workspace (check the adapter node)
    • inward mappings include the tag
    • outward mappings include topic filter, tag and field mapping instructions

The result is Edge with a full set of functionalities mostly devoid of mocks and magic tricks. Note that the alignment is done with the current state of master, which doesn't implement all the required endpoints.

Out-of-scope

After

screenshot-localhost_3000-2024_11_27-16_47_06

screenshot-localhost_3000-2024_11_27-16_47_58

screenshot-localhost_3000-2024_11_27-16_48_29

screenshot-localhost_3000-2024_11_27-16_48_53

screenshot-localhost_3000-2024_11_27-16_49_30

@vanch3d vanch3d self-assigned this Nov 25, 2024
@vanch3d vanch3d added the do not merge Do not merge until this label is removed. label Nov 25, 2024
@cla-bot cla-bot bot added the cla-signed label Nov 26, 2024
@vanch3d vanch3d marked this pull request as ready for review November 28, 2024 12:03
@vanch3d vanch3d marked this pull request as draft November 28, 2024 16:08
@vanch3d vanch3d marked this pull request as ready for review November 28, 2024 16:32
@vanch3d vanch3d requested a review from h2xd November 28, 2024 16:32
@vanch3d vanch3d removed the do not merge Do not merge until this label is removed. label Nov 28, 2024
@vanch3d vanch3d merged commit 99954bd into master Nov 29, 2024
10 checks passed
@vanch3d vanch3d deleted the refactor/28015/align-backend branch November 29, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants