Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Configurable wait timeout for page to load #713

Open
stopwatch2208 opened this issue Dec 2, 2024 · 1 comment
Open
Labels
feature request New feature or request

Comments

@stopwatch2208
Copy link

Currently there is hard-coded value of 5 seconds to wait for page to load. While this works for majority of use cases I see that sometimes this is not enough and screenshots are incomplete. Sites that have excessive javascript or loading bars may take longer before they allow to see the page.

Problem code

new Promise((f) => setTimeout(f, 5000)),

Possible implementation would allow user to configure CRAWLER_SCREENSHOT_WAIT_SECONDS (or similar) environmental variable which would default to 5 (5 seconds). This would allow user to configure wait time before screenshot is taken.

@MohamedBassem MohamedBassem added the feature request New feature or request label Dec 9, 2024
@MohamedBassem
Copy link
Collaborator

I think this is a reasonable feature request. If you're familiar with typescript and would be willing to send a PR, I'd be happy to merge it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants