Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish between Video URLs and embedded videos on a page #729

Open
1 task done
ctschach opened this issue Dec 12, 2024 · 1 comment
Open
1 task done

Distinguish between Video URLs and embedded videos on a page #729

ctschach opened this issue Dec 12, 2024 · 1 comment
Labels
feature request New feature or request

Comments

@ctschach
Copy link

ctschach commented Dec 12, 2024

Describe the feature you'd like

When you turn on the video download option, I notice that you'll also download embedded videos from a page. This could result in an unexpected amount of data on your hard drive (and that's probably why this is turned off by default) and it's probably not what you want. However, pasting a YouTube Video URL to download a video would be nice.

So it would be great if you could distinguish between video URLs (like YouTube, Vimeo) you paste as a new item and URLs that are referenced on a page. Maybe you can just define a regular expression when to turn video download on and when not.

Something like:

myregex = "(.*youtube.*|.*vimeo\.com.*)
if re.search(myregex, url) is not None:
     downloadVideos = true

Describe the benefits this would bring to existing Hoarder users

You would not end up with unexpected hdd usage for pages that contained videos you are not aware of.

Can the goal of this request already be achieved via other means?

It seams like you can tweak this setting only when launching the container. So "no"

Have you searched for an existing open/closed issue?

  • I have searched for existing issues and none cover my fundamental request

Additional context

No response

@kamtschatka
Copy link
Collaborator

A youtube link is also not a video, it is simply a webpage with an embedded video on it.
Adding a list of domains where the video downloader runs might be an option though. Regex is also an option, but I am working on a tool that also allows you to specify a regex and people are simply not capable of understanding how they work (especially since "." means any character).
I think a simple list of comains that get compared might make this feature a lot more user friendly.

@kamtschatka kamtschatka added the feature request New feature or request label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants