-
-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Linux install script and documentation #707
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing, thanks a LOT for porting it and opening a PR! Looks good to me, left a couple of small comments.
I'm curious, is there any reason why we're swallowing the output of all commands? While the installation is happening, it seems to me as if process is stuck. Maybe that's the convention in proxmox scripts, but do we need to do that here? I know it'll probably make it harder to see the output messages, but at least it shows the progress of the installation? |
That's the convention in the Proxmox scripts, so it looks all nice, but they have a flag to enable verbose mode. I lack the finesse to make a progress indicator, at least within a reasonable amount of time 😄 If you don't mind the script having all the output and looking quite busy as it runs, I'm happy to stop supressing the output. |
@vhsdream Yeah, I'm trying the script now and trying to figure out what it's doing. I don't think you need to do progress bars, I think just removing the suppression would be good enough. |
@MohamedBassem I'll add progress indications in a later version 😉 |
Thanks again @vhsdream! |
Hi @MohamedBassem - thank you so much for your help with getting the Proxmox LXC script going. Hopefully it's ready to be merged soon!
This PR adds an all-in-one bash installer/updater script that is very similar to the ones in their repo. It adds most of the suggestions that you had for that one, such as separating the data and config dirs from the install dir, but also adds support for Ubuntu 24.04 as well as Debian 12. I have tested it extensively on both platforms.
I've also written the documentation for the script because I figured why not?
Please let me know what you think and if this would be a good addition to installation methods for Hoarder.