Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General refactoring #1

Open
climategadgets opened this issue Sep 18, 2021 · 0 comments
Open

General refactoring #1

climategadgets opened this issue Sep 18, 2021 · 0 comments
Labels
legacy Issues related to bit rot - there's been a lot of it since 2000 STICKY Issues with this label will not be closed so they are visible at all times

Comments

@climategadgets
Copy link
Member

No particular intent or acceptance criteria; placeholder for all random things that could use some TLC.
@climategadgets climategadgets added the legacy Issues related to bit rot - there's been a lot of it since 2000 label Sep 18, 2021
climategadgets added a commit that referenced this issue Sep 19, 2021
@climategadgets
Bumped dependencies up (#1)
e4fde28
climategadgets added a commit that referenced this issue Sep 19, 2021
@climategadgets
Replaced JUnit 4 with 5, added AssertJ (#1)
6d3144f
climategadgets added a commit that referenced this issue Sep 19, 2021
@climategadgets
Added the notion of a "family" (#1)
07a3490
climategadgets added a commit that referenced this issue Sep 19, 2021
@climategadgets
Replaced integer speed with an enum (#1)
34a5c7c
climategadgets added a commit that referenced this issue Sep 19, 2021
@climategadgets
Replaced integer power level with an enum (#1)
9dc140d
climategadgets added a commit that referenced this issue Sep 19, 2021
@climategadgets
Replaced integer reset result with enum (#1)
8299aeb
climategadgets added a commit that referenced this issue Sep 19, 2021
@climategadgets
Replaced integer power change condition with enum (#1)
399123a
climategadgets added a commit that referenced this issue Sep 19, 2021
@climategadgets
Replaced integer power duration with enum (#1)
e0c31d9
climategadgets added a commit that referenced this issue Sep 19, 2021
@climategadgets
Minor refactoring (#1)
7bf0293
climategadgets added a commit that referenced this issue Sep 19, 2021
@climategadgets
Minor refactoring: eliminated Vector, simplified code (#1)
44b7fff
climategadgets added a commit that referenced this issue Sep 19, 2021
@climategadgets
Removed deprecation notice - this was inconsequential (#1)
4e0ff5b 
Long story: https://diy-zoning.blogspot.com/2010/01/memory-leak-hunt-aftermath.html
climategadgets added a commit that referenced this issue Sep 19, 2021
@climategadgets
Minor refactoring (#1)
d9680a5
climategadgets added a commit that referenced this issue Sep 19, 2021
@climategadgets
Replaced Enumeration with Iterator, handled ripples (#1)
a408704
climategadgets added a commit that referenced this issue Sep 20, 2021
@climategadgets
Minor refactoring: adapterDetected() (#1)
ce2446c
climategadgets added a commit that referenced this issue Sep 20, 2021
@climategadgets
Minor refactoring (#1)
7827eff 
Mostly removed redundant documentation on @OverRide method, redundant throws
statement, and renamed snake case variables
climategadgets added a commit that referenced this issue Sep 20, 2021
@climategadgets
Removed override adapter (never used), simplified max baud calculation (
304fab4 
#1)
climategadgets added a commit that referenced this issue Sep 20, 2021
@climategadgets
Documentation update (#1)
77daeeb
climategadgets added a commit that referenced this issue Sep 20, 2021
@climategadgets
Documentation update, minor refactoring (#1)
b430995
climategadgets added a commit that referenced this issue Sep 20, 2021
@climategadgets
Replaced command constants with enums (#1)
6ccdc1c
climategadgets added a commit that referenced this issue Sep 20, 2021
@climategadgets
Documentation update (#1)
b02188e
climategadgets added a commit that referenced this issue Sep 20, 2021
@climategadgets
Replaced command constants with enums (#1)
b8cb4fb
climategadgets added a commit that referenced this issue Sep 20, 2021
@climategadgets
Documentation update (#1)
2fd9e62
climategadgets added a commit that referenced this issue Sep 20, 2021
@climategadgets
Replaced integer commands (MemoryBankEEPROMstatus specific) with enums (
2b900fc 
#1)
climategadgets added a commit that referenced this issue Sep 20, 2021
@climategadgets
Documentation update, trivial refactoring (#1)
d2f5ff9
climategadgets added a commit that referenced this issue Sep 20, 2021
@climategadgets
Documentation update, trivial refactoring (#1)
056a307
climategadgets added a commit that referenced this issue Sep 20, 2021
@climategadgets
Documentation update, trivial refactoring (#1)
618a555
climategadgets added a commit that referenced this issue Sep 20, 2021
@climategadgets
Replaced Enumeration with List (#1)
db2ffc1
climategadgets added a commit that referenced this issue Sep 20, 2021
@climategadgets
Code review, documentation update (#1)
e08e56e
climategadgets added a commit that referenced this issue Sep 21, 2021
@climategadgets
Code review, documentation update (#1)
9cc2ca7
climategadgets added a commit that referenced this issue Sep 21, 2021
@climategadgets
Replaced Enumeration with Iterator (#1)
a320a36
climategadgets added a commit that referenced this issue Sep 21, 2021
@climategadgets
Minor refactoring (#1)
7566898
climategadgets added a commit that referenced this issue Sep 21, 2021
@climategadgets
Suppressed Sonar nit for an unavoidable unchecked conversion (#1)
6b9cba5
climategadgets added a commit that referenced this issue Sep 21, 2021
@climategadgets
Replaced Enumeration with Iterator (#1)
5171dd1
climategadgets added a commit that referenced this issue Sep 21, 2021
@climategadgets
Documentation update, minor refactoring (#1)
442bb85
climategadgets added a commit that referenced this issue Sep 25, 2021
@climategadgets
SerialService is no longer a SerialPortEventListener - this was never…
e9ad6bc 
… used (#1)
climategadgets added a commit that referenced this issue Sep 25, 2021
@climategadgets
Shifted responsibility of keeping at rack on open ports to callers (#1)
c3331ac 
Also, fast failing on attempts to open a port that is already open.
climategadgets added a commit that referenced this issue Sep 25, 2021
@climategadgets
Minor refactoring (#1)
ac17d19
climategadgets added a commit that referenced this issue Sep 25, 2021
@climategadgets
Replaced currentTimeMillis()/long with Clock/Duration (#1)
b28b9a9
climategadgets added a commit that referenced this issue Sep 25, 2021
@climategadgets
Removed getSerialService() (#1)
263ab4f
climategadgets added a commit that referenced this issue Sep 25, 2021
@climategadgets
Code review, trivial refactoring (#1)
a4399db
climategadgets added a commit that referenced this issue Sep 25, 2021
@climategadgets
Eliminated feature envy case (#1)
ddf28ad
climategadgets added a commit that referenced this issue Sep 27, 2021
@climategadgets
Deprecated OneWireAccessProvider, it introduces unnecessary hassle (#1)
41a13dc
climategadgets added a commit that referenced this issue Sep 27, 2021
@climategadgets
Trivial refactoring (#1)
1b2f4ea
climategadgets added a commit that referenced this issue Sep 27, 2021
@climategadgets
Removed never used max baud rate property - seems to work nicely at 1…
d6cec88 
…15200 (#1)
climategadgets added a commit that referenced this issue Sep 27, 2021
@climategadgets
Made OWPathElement immutable (#1)
dc979db
climategadgets added a commit that referenced this issue Sep 27, 2021
@climategadgets
OWPathElement: OneWireContainer (too wide) => SwitchContainer (just r…
5354c10 
…ight) (#1)
climategadgets added a commit that referenced this issue Sep 27, 2021
@climategadgets
OWPathElement: OneWireContainer (too wide) => SwitchContainer (just r…
3d4ac2d 
…ight) (#1)
climategadgets added a commit that referenced this issue Sep 28, 2021
@climategadgets
Updated 1-Wire command set (#1)
6a2aa92
climategadgets added a commit that referenced this issue Sep 28, 2021
@climategadgets
Code review: OneWireContainer1F (DS2409) (#1)
60c2bba
climategadgets added a commit that referenced this issue Sep 28, 2021
@climategadgets
Addressed some ErrorProne nits (#1)
fbe0dee
climategadgets added a commit that referenced this issue Oct 1, 2021
@climategadgets
OneWireContainer10: trivial refactoring (#1)
d812e94
climategadgets added a commit that referenced this issue Oct 4, 2021
@climategadgets
Moved OWPath towards immutability (#1)
dad72d9
climategadgets added a commit that referenced this issue Oct 4, 2021
@climategadgets
Moved OWPath towards immutability (#1)
917ec8d
climategadgets added a commit that referenced this issue Oct 4, 2021
@climategadgets
Moved OWPath towards immutability (#1)
a33d797
climategadgets added a commit that referenced this issue Oct 4, 2021
@climategadgets
Moved OWPath towards immutability (#1)
398f424
@climategadgets climategadgets added the STICKY Issues with this label will not be closed so they are visible at all times label Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
legacy Issues related to bit rot - there's been a lot of it since 2000 STICKY Issues with this label will not be closed so they are visible at all times
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@climategadgets