Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for DMG inside a ZIP #189

Open
n8felton opened this issue May 18, 2021 · 1 comment
Open

Support for DMG inside a ZIP #189

n8felton opened this issue May 18, 2021 · 1 comment
Assignees
Labels

Comments

@n8felton
Copy link

I'm not sure if this is something that happens often (or why software vendors think it's necessary), but I have a ZIP download that contains a DMG.

To Reproduce

# ./recipe-robot -vv --keep-cache https://www.finaldraft.com/downloads/finaldraft1200b57Mac.zip
Processing: https://www.finaldraft.com/downloads/finaldraft1200b57Mac.zip
Input path looks like a download URL.
    Download URL is: https://www.finaldraft.com/downloads/finaldraft1200b57Mac.zip
Downloading file for further inspection...
    Download content-type is application/zip
################################################################################################################################# 100.0%
    Downloaded to /Users/n8felton/Library/Caches/Recipe Robot/2021-05-18_12-10-21_286621/finaldraft1200b57Mac.zip
Determining download format...
    File extension is zip
    Successfully unarchived zip
[ERROR] I wasn't able to gather enough information about this app to make recipes. If you saw any warnings above, they may contain more specific information.

# ls '/Users/n8felton/Library/Caches/Recipe Robot/2021-05-18_12-10-21_286621/unpacked'
Final Draft 12.dmg

Expected behavior
Should Recipe Robot be attempting to find a DMG inside a ZIP?

  • macOS: 10.15.7
  • Recipe Robot Version: 2.2.0
  • autopkg version: 2.1
  • /usr/local/autopkg/python --version: Python 3.7.5
@homebysix
Copy link
Owner

It's difficult to explain why a vendor would do this. The dmg is already compressed; wrapping it inside a zip adds no benefit at all.

Not a top priority, but I'll keep this issue open to consider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants