Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCSS Method getShade works on lightness value instead of percentage #382

Open
drapisarda opened this issue Mar 25, 2020 · 0 comments
Open

SCSS Method getShade works on lightness value instead of percentage #382

drapisarda opened this issue Mar 25, 2020 · 0 comments

Comments

@drapisarda
Copy link
Contributor

drapisarda commented Mar 25, 2020 •
edited
Loading

getShade() ( in styles/_colors.scss) works on the lightness property of the passed color (in a HSL way). This means that the same variation value generates different results for different colours. Other than that, getShade() could also shot an error. Example:
getShade($crusta-orange, 29)
generates
image

We could solve this

  • using SCSS lighten method, but then we have to change how we measure the variations
  • force $new-lightness to be alwasy >= 0 with an if .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@drapisarda