Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@hono/oauth-providers: custom state for Facebook auth #823

Open
jacoscaz opened this issue Nov 12, 2024 · 2 comments
Open

@hono/oauth-providers: custom state for Facebook auth #823

jacoscaz opened this issue Nov 12, 2024 · 2 comments

Comments

@jacoscaz
Copy link

jacoscaz commented Nov 12, 2024

Hello!

I just noticed that the facebookAuth function doesn't support passing custom values for the state param, which is always set to a random value:

However, the googleAuth function does allow this:

const newState = options.state || getRandomState()

Would you accept a PR that would allow passing custom state values through facebookAuth?

@yusukebe
Copy link
Member

Hi @jacoscaz thank you for raising the issue.

@monoald What do you think of this?

@jacoscaz
Copy link
Author

For the time being I'll vendor this package within my own project and test the proposed change. If everything works well I'd be happy to open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants