Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[firebase/auth] Unmaintained #912

Closed
hls-app opened this issue Dec 27, 2024 · 8 comments
Closed

[firebase/auth] Unmaintained #912

hls-app opened this issue Dec 27, 2024 · 8 comments
Labels
enhancement New feature or request

Comments

@hls-app
Copy link

hls-app commented Dec 27, 2024

Which middleware is the feature for?

@hono/firebase-auth

What is the feature you are proposing?

The core package firebase-auth-cloudflare-workers seems not maintained and Cloudflare Workers now support node:crypto X509Certificate

There is an active issue and there is a fork that fixes this issue.

Auth seems to be a critical part and would be great if this will have first party support.

@hls-app hls-app added the enhancement New feature or request label Dec 27, 2024
@hls-app hls-app changed the title [firebase/auth] [firebase/auth] Unmaintained Dec 27, 2024
@hls-app
Copy link
Author

hls-app commented Dec 27, 2024

Also, there is another package that uses X509 instead of JWK https://www.npmjs.com/package/@fiboup/hono-firebase-auth

@yusukebe
Copy link
Member

@hls-app

Thank you for the issue.

@Code-Hex, can you keep maintaining the @hono/firebase-auth?

@hls-app If you are OK with it, you can be a maintainer of the @hono/firebase-auth.

@hls-app
Copy link
Author

hls-app commented Dec 28, 2024

Will wait for @Code-Hex to respond. Otherwise, I might be able to help with @hono/firebase-auth

@Code-Hex
Copy link
Contributor

@hls-app I didn't notice that. I will check it

@Code-Hex
Copy link
Contributor

Code-Hex commented Dec 29, 2024

@hls-app Now that I have released the latest version with everything you want, you can contribute to @hono/firebase-auth, do you want a challenge?

https://github.com/Code-Hex/firebase-auth-cloudflare-workers/releases/tag/v2.0.5
https://github.com/Code-Hex/firebase-auth-cloudflare-workers/releases/tag/v2.0.6

@hls-app
Copy link
Author

hls-app commented Dec 31, 2024

Thanks @Code-Hex .

I have kind of already implemented this using https://github.com/fiboup/edgelibs/blob/main/packages/hono-firebase-auth/src/middleware.ts

I think it is super simple and works perfect for my use case. I only need to validate the token and nothing more.

It has got a validation issue but otherwise, looks super straightforward.

@Code-Hex
Copy link
Contributor

Code-Hex commented Dec 31, 2024

@hls-app I'm not sure, but I think @hono/firebase-auth would be just as simple if it didn't deal with cookies. Can you give me an example of how you feel it's complicated?

CleanShot 2024-12-31 at 10 11 43@2x

Anyway, I'm waiting for your @hono/firebase-auth PR!

@hls-app
Copy link
Author

hls-app commented Jan 1, 2025

@Code-Hex Like I said, I think there is no need for JWK setup or KV setup in my use case.

All I want to check is if the provided token is valid for a given project id. The package I mentioned only needs a project id and it just validates the token using the Google Public Key.

I might be happy to create a new fork to simplify a few things in that package but so far for my use case, that package serves well for now.

@hls-app hls-app closed this as completed Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants