Skip to content
This repository has been archived by the owner on Oct 5, 2024. It is now read-only.

Fix CI when using git worktree #103

Closed
robsavoye opened this issue Jan 8, 2022 · 8 comments
Closed

Fix CI when using git worktree #103

robsavoye opened this issue Jan 8, 2022 · 8 comments
Assignees
Milestone

Comments

@robsavoye
Copy link
Collaborator

robsavoye commented Jan 8, 2022

When working on multiple branches using "git worktree", the CI fails to clone the git repository due to the path being different. This isn't a problem when using the older 'git-new-workdir", but using 'git worktree' is preferred.

@robsavoye robsavoye added type:bug Something isn't working priority:medium labels Jan 8, 2022
@robsavoye
Copy link
Collaborator Author

Another issue is the current docker image for the dependencies was created by a contractor, and can only be modified by that contractor. Currently it's missing a critical dependency, jemalloc. The docker image for the library image should be in a docker hub using a generic tech team account, so it can be updated and maintained. Till then, all CI test on GitHub will fail.

@dakotabenjamin
Copy link
Member

Adding some context for the current issue:

 checking for git... /usr/bin/git
configure: Using Jemalloc instead of system malloc
checking osmium/osm/node.hpp usability... yes
checking osmium/osm/node.hpp presence... yes
checking for osmium/osm/node.hpp... yes
checking for boostlib >= 1.69 (106900)... yes
checking whether the Boost::System library is available... yes
checking for exit in -lboost_system... no
checking for exit in -lboost_system... (cached) no
checking for exit in -lboost_system... (cached) no
configure: error: Could not link against boost_system !

Task would be to check the docker image locally, fix any build issues when running the above exec command and then push the new image yml to the repository branch update/docker-ci which will deploy a new version to quay.io

@emi420
Copy link
Collaborator

emi420 commented Mar 3, 2023

@dakotabenjamin @robsavoye @eternaltyro

This is still needed or can I close the issue?

@emi420 emi420 assigned emi420 and unassigned eternaltyro Mar 3, 2023
@emi420 emi420 added this to the Q2 - 2023 milestone Apr 25, 2023
@emi420 emi420 modified the milestones: Q2 2023, Q3 2023 Jul 12, 2023
@emi420 emi420 moved this to Todo in Underpass 2023-2024 Oct 9, 2023
@emi420 emi420 modified the milestones: Q3 2023, Q4 2023 Oct 9, 2023
@emi420 emi420 moved this from Todo to In Progress in Underpass 2023-2024 Oct 23, 2023
@emi420 emi420 modified the milestones: Q4 2023, Beta version Nov 6, 2023
@emi420
Copy link
Collaborator

emi420 commented Nov 8, 2023

@spwoodcock optimization is good, but this is the issue that we need to solve, that's publishing the Underpass docker image.

What's needed is only the publishing of the underpass image (not UI, API, etc..). Please take a look if you can, without including other changes on directory structure or ports, so we can solve the issue and then continue with other things.

@spwoodcock
Copy link
Member

spwoodcock commented Nov 9, 2023

Can you give me write access to the repo, to facilitate this please?

Otherwise, read access is fine, but I also need permission to write to the package (container) registry.

edit
Also, if there any downside to publishing the api and ui? It's a few lines of code.

@spwoodcock
Copy link
Member

This is complete in #444
Moved from Quay to GHCR, to give us better control and nicer integration with Github workflows.
There are multiple other advantages too:

  • Less config.
  • Multi architecture builds (arm anyone?).
  • Supports build args (a major feature lacking in Quay, without configuring webhooks).
  • Auto image tagging.
  • Buildkit, for much fast image builds and caching.
  • Can use reusable gh-workflows repo.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Underpass 2023-2024 Nov 9, 2023
@emi420 emi420 reopened this Nov 20, 2023
@emi420 emi420 moved this from Done to In Progress in Underpass 2023-2024 Nov 20, 2023
@emi420 emi420 added priority:low and removed type:bug Something isn't working priority:medium labels Nov 20, 2023
@spwoodcock
Copy link
Member

What's the issue that needs to be fixed?

Doesn't PR #444 solve it?

@emi420
Copy link
Collaborator

emi420 commented Dec 1, 2023

All solved! thanks @spwoodcock

@emi420 emi420 closed this as completed Dec 1, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Underpass 2023-2024 Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Status: Done
Development

No branches or pull requests

5 participants