Skip to content

Implement maintenance mode #8

Open
poma opened this issue Sep 1, 2017 · 3 comments
Open

Implement maintenance mode #8

poma opened this issue Sep 1, 2017 · 3 comments

Comments

@poma
Copy link
Member

poma commented Sep 1, 2017

Prevent uploader from marking all replays as upload error when website is under maintenance. Add maintenance=true to website response and implement waiting on client.

@poma poma mentioned this issue Oct 2, 2017
@martijnhoekstra
Copy link
Collaborator

Is this implemented on the serverside yet? The http way would be to respond with 503 -- service unavailable, and a retry-after header set. Then the client could wait until, well, after.

@poma
Copy link
Member Author

poma commented Dec 6, 2019

I don't think we have this on the server. Laravel has artisan down command, we probably need to check what response it returns on all requests and use this as a signal for maintenance.

@martijnhoekstra
Copy link
Collaborator

https://laracasts.com/discuss/channels/laravel/artisan-down-change-view tells me

See https://laravel.com/docs/5.6/errors#custom-http-error-pages

artisan down returns a 503 error so you should create the following file: resources/views/errors/503.blade.php

That it's already a 503 is good, we can detect that. retry-after headers are nice, we can deal with that when we get there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants