Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please make _run_test_class and _run_test_method public #88

Closed
Ovid opened this issue Dec 16, 2017 · 3 comments
Closed

Please make _run_test_class and _run_test_method public #88

Ovid opened this issue Dec 16, 2017 · 3 comments

Comments

@Ovid
Copy link
Contributor

Ovid commented Dec 16, 2017

It's trivial to override the executor in Test::Class::Moose::Runner to make a custom subclass, but when subclassing Test::Class::Moose::Executor::Sequential, I have to use the private methods _run_test_class and _run_test_method with my before modifiers.

It would be lovely if those were made public so I didn't feel too guilty about those. If those were public, I could easily publish modules which allow verbose output like the following (without needing to extend functionality with PRs such as #76):

screen shot 2017-12-16 at 11 15 43 am

@autarch
Copy link
Member

autarch commented Dec 16, 2017

Seems like a good idea. We should probably also have a public run_test_instance too.

@autarch
Copy link
Member

autarch commented Dec 16, 2017

I also realized that for this to really function properly you need a way to pass roles to be applied to the executor into the runner class. Right now it hard codes the Sequential & Executor class names, so there's no way to tell it to use a subclass. Allowing arbitrary roles to be applied to the executor would make it easier for folks to write plugins.

@autarch
Copy link
Member

autarch commented Dec 23, 2017

This is done in v0.92.

@autarch autarch closed this as completed Dec 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants