-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Old state shown on previous pages on active inhibitor change #668
Labels
Comments
tamslo
added
Study: Must have
Study: Could have
Study: Should have
P: App
Project: App
T: Fix
Type: Bug Fixes
and removed
Study: Could have
Study: Should have
labels
Oct 17, 2023
tamslo
added a commit
that referenced
this issue
Nov 21, 2023
tamslo
added a commit
that referenced
this issue
Nov 22, 2023
tamslo
added a commit
that referenced
this issue
Nov 22, 2023
tamslo
added a commit
that referenced
this issue
Nov 22, 2023
tamslo
added a commit
that referenced
this issue
Nov 22, 2023
tamslo
added a commit
that referenced
this issue
Nov 22, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Desired behavior: for the gene report and drug search tab, data should update in the respective inactive tab after an active medication change (optimally; always also possible)
Currently implementing: solution using ChangeNotifier
UserData.instance.activeDrugNames
is used to manipulate activeMedicationsUserData.instance.activeDrugNames
is used in the UIPossible solutions
maintainState: false
toAutoRoute
definitions inlib/report/module.dart
andlib/search/module.dart
(see StackOverflow)lib/common/pages/drug/widgets/annotation_cards/drug.dart
(insideCupertinoDialogAction:onPressed
)Navigator.popUntil(context, (route) => false);
: Removes everything from the router (including tabs) and throws unhandled exceptionsmaintainState: false
to root child routes (see above): works perfectly for report page reset but not drugs page, probably due to filter state; also not optimal from usability perspective, would be better if data just updatesmaintainState
and will have same problems as aboveCode that does not work but might be useful in the future: get dependent tab and navigate to root:
The text was updated successfully, but these errors were encountered: