Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using explicit dependencies checks on CI #153

Open
keynmol opened this issue Nov 25, 2020 · 2 comments
Open

Using explicit dependencies checks on CI #153

keynmol opened this issue Nov 25, 2020 · 2 comments
Labels

Comments

@keynmol
Copy link

keynmol commented Nov 25, 2020

  1. Use https://github.com/cb372/sbt-explicit-dependencies do declare all dependencies
  2. Enable undeclaredCompileDependenciesTest and unusedCompileDependenciesTest (to avoid test dependencies evicting main ones) on the CI

This can be tackled module by module, I think.

@rossabaker
Copy link
Member

  • unusedCompileDependenciesTest is already enforced.

  • undeclaredCompileDependenciesTest was introduced, and backed off, in Declare more dependencies http4s#3880. A lot of the work to re-enable that is in an intermediate commit. And if we'd gone with that, we would not have had this bug.

  • cats-laws shouldn't be a compile dependency of http4s-client, or most modules. That may be an orthogonal issue: I am unsure whether that triggered the test dependency to upgrade our core dependency.

@rossabaker
Copy link
Member

The rest of the team hates this, but I still contend we're running with scissors without it.

@armanbilge armanbilge transferred this issue from http4s/http4s May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants