-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with step and reset in TempVMPackingEnv #36
Comments
Could you please let me know how to use VMPacking-v1 or VMPacking-v0. I'm not sure how to set up the env_config for this. Any help would be greatly appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi team,
Awesome work, really like the paper.
I've found a couple of issues with the TempVMPackingEnv environment (VMPacking-v1).
The main one is that the custom logic of the step method was definied as
step()
instead of_STEP()
and so steps in the environment were actually using_STEP()
for the parent class. There's is also a small indexing error when demand is being removed from a PM, and I think it would be helpful to also round down any remaining use below tolerance to zero.There was also an issue in the
_RESET()
method, wherestate
was being created as an array istead of a dict, and so updates to the state, based on dict keys, did not work.Proposed fixes below, with a comment followed by my initials (JMF) and an explanation for each changed/added line. Happy to raise a pull request if helpful.
The text was updated successfully, but these errors were encountered: