-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug with response logic #3
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
According to the docs: https://developers.yubico.com/yubikey-val/Validation_Protocol_V2.0.html a 200 response is returned under multiple conditions including if the Id is incorrect but present as well as other conditions. This leads to a situation where if a parameter is missing, such as inputting an incorrect value for the api id, the bot responds that it has invalidated the OTP because the response was 200, but in fact, the status is MISSING_PARAMETER instead.
This should match the response text on
"status=OK"
instead and probably handle the other response statuses as well, especially those that the user controls.From the docs:
The text was updated successfully, but these errors were encountered: