Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Square brackets for compound sort key syntax in DBT #3

Open
patdough5 opened this issue Jan 2, 2019 · 3 comments
Open

Square brackets for compound sort key syntax in DBT #3

patdough5 opened this issue Jan 2, 2019 · 3 comments

Comments

@patdough5
Copy link

While working on creating a small DBT file, the discussion of whether or not to use () or [] came up when referring to compound keys. @tjengel pointed out that DBT docs refer to using []. Documentation can be found here

@atharvai
Copy link

atharvai commented Jan 2, 2019

sort accepts a list of sort keys,

A list in python is denoted using [] not () which is a tuple. Hopefully this isn't a point of contention.

@patdough5
Copy link
Author

patdough5 commented Jan 2, 2019

Typo, my bad Atharva. It is more for consistency and following DBTs docs.

@patdough5 patdough5 changed the title Square brackets for compound key lists in DBT Square brackets for compound sort key syntax in DBT Jan 2, 2019
@tmastny
Copy link
Contributor

tmastny commented Jan 10, 2019

If the docs say we should use lists instead of tuples, that's what we should do. I think it is just a coincidence that tuples work, likely because they both implement the iterator methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants