From a7541cac2294e691b1ed35a629ba52b49c66f10d Mon Sep 17 00:00:00 2001 From: Sherry Zhang Date: Thu, 21 Apr 2022 23:25:43 +1000 Subject: [PATCH] add back dontrun for glyph and add cran comments for this --- R/map-glyph.R | 2 ++ cran-comments.md | 1 + man/glyph.Rd | 2 ++ 3 files changed, 5 insertions(+) diff --git a/R/map-glyph.R b/R/map-glyph.R index 993207c8..e4813df8 100644 --- a/R/map-glyph.R +++ b/R/map-glyph.R @@ -20,6 +20,7 @@ #' @rdname glyph #' @return a ggplot object #' @examples +#' \dontrun{ #' library(ggplot2) #' # basic glyph map with reference line and box--------------- #' ggplot(data = GGally::nasa, @@ -50,6 +51,7 @@ #' y_major = lat, y_minor = surftemp), #' width = rel(0.8), height = 1) + #' theme_bw() +#' } #' geom_glyph <- function(mapping = NULL, data = NULL, stat = "identity", position = "identity", ..., x_major = NULL, diff --git a/cran-comments.md b/cran-comments.md index 96cc4e3f..b0ba78c0 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -6,3 +6,4 @@ Duration: 2m 3.1s R CMD check succeeded * This is a new release. +* The glyph examples take ~8s to run, which is beyond the 5s limit of CRAN check, hence it is wrapped in \dontrun. diff --git a/man/glyph.Rd b/man/glyph.Rd index 372bd3ee..6111b968 100644 --- a/man/glyph.Rd +++ b/man/glyph.Rd @@ -129,6 +129,7 @@ a ggplot object Create glyph map with ggplot2 } \examples{ +\dontrun{ library(ggplot2) # basic glyph map with reference line and box--------------- ggplot(data = GGally::nasa, @@ -159,5 +160,6 @@ ggplot() + y_major = lat, y_minor = surftemp), width = rel(0.8), height = 1) + theme_bw() +} }